George Niculae wrote: > --- On Thu, 3/11/10, Paul Mossman <[email protected]> wrote: > >> George wrote: >> >>> wrt http://track.sipfoundry.org/browse/XX-7864 : IMO >>> >> escaping >> >>> special characters in phonebook contacts should be >>> >> handled at >> >>> phone plugin level (like SMC 3456 phone that is using >>> >> XML >> >>> file for phonebook), not in PhoneContext. >>> >>> Let me know your thoughts on this >>> >> I thought the XX-7864 problem was that the '&' resulted >> in an empty last >> name, and the entry was then tossed. (I don't see any >> PhoneContextImpl >> escaping added by the path.) >> Yes, that was the problem. >> With the XX-7864 patch, is the SMC 3456 able to show a >> "Marks & Spencer" >> contact? >> >> Yes, with this patch the SMC 3456 correctly shows "Marks & Spencer". > I don't have a SMC 3456 configured but I don't think the patch solves all > issues - from an e-mail discussion with Chris: > > "I believe, after extensive testing and eliminating one by one of my 55 Gmail > contacts, I have found the issue why my Contacts were not being seen in SMC > 3456 but your were - It seems that the character "&" is not accepted > somewhere during the import/conversion from Phonebook Contacts to the SMC > 3456. > > The contact "Chris & Laura Parfitt" is the one that should be preventing the > SMC 3456 from downloading any of the Gmail contacts to the SMC 3456. > > If you change this to "Chris and Laura Parfitt" it will then work correctly > > Note the "&" works fine on the Polycom set Contact Directory " > > The patch is OK (we should consider an entry to be valid if first name or > last name are not empty) but it needs to be enhanced with special chars > escaping functionality. > > George The patch as it is now, I think it does solve the issue, as I of course tested it and it correctly shows "Marks & Spencer" . I guess that the "&" doesn't break the xml file that contains the contact directory and it seems that SMC 3456 treats it ok. BUT, I think that in general it may be good havind a helper class as George suggested that would escape special chars for xml. However, I don't know if we should include it in this patch or create a separate Jira. Anyway, I'll make some more tests with special chars and let you all know.
Bogdan. _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
