I have just merged from a private branch into main some significant upgrades to the Url class. In particular, it how carefully checks that the text after the parsable part of the input string looks like it should, that is, is either empty or starts with a comma. This causes the parser to detect error cases that it previously did not. I've also installed a number of additional tests of these behaviors.
I invite anyone who is interested to review this code, and especially to submit tests for cases that I have overlooked. Dale ________________________________________ From: [email protected] [[email protected]] On Behalf Of [email protected] [[email protected]] Sent: Thursday, April 15, 2010 11:14 AM To: [email protected] Subject: sipXecs 18587 dworley: Update Url to properly detect the end of the URI and verify that the Project sipXecs New Revision 18587<http://code.sipfoundry.org//changelog/sipXecs/?cs=18587> Committer dworley Date 2010-04-15 10:13:03 -0500 (Thu, 15 Apr 2010) Log Update Url to properly detect the end of the URI and verify that the following text is acceptable in the context. Upgrade Url tests. Merged revisions 17808,17811-17842 via svnmerge from https://sipxecs.sipfoundry.org/rep/sipXecs/branches/user_dworley_post4.2 ........ r17808 | dworley | 2010-01-26 21:08:02 -0500 (Tue, 26 Jan 2010) | 4 lines Clarify comments in Url.h This is the first part of reverting rev. 17677, that is, re-installing revs. 17626, 17649, and 17662. ........ r17811 | dworley | 2010-01-26 22:38:31 -0500 (Tue, 26 Jan 2010) | 4 lines Update Url::parseString() to correctly test what follows an apparent URI. This is the second part of reverting rev. 17677, that is, re-installing revs. 17626, 17649, and 17662. ........ r17818 | dworley | 2010-01-27 15:40:12 -0500 (Wed, 27 Jan 2010) | 6 lines Update Utl::parseString() to properly integrate the new field-parameter parsing with the code that checks that the text following the URI is a proper separator for the mode of invocation. Add UtlTest::testErrors to test Utl::parseString's testing of text following a URI.. ........ r17822 | dworley | 2010-01-27 22:39:53 -0500 (Wed, 27 Jan 2010) | 3 lines Update UrlTest::testBigUriScheme and UrlTest::testBigUriHost now that Url::parseString() parses big tokens correctly. ........ r17826 | dworley | 2010-01-27 23:01:34 -0500 (Wed, 27 Jan 2010) | 2 lines Correct comment. ........ r17827 | dworley | 2010-01-27 23:16:25 -0500 (Wed, 27 Jan 2010) | 2 lines Improve formatting. ........ r17831 | dworley | 2010-01-28 12:13:05 -0500 (Thu, 28 Jan 2010) | 2 lines Improve comment. ........ r17841 | dworley | 2010-01-28 22:04:35 -0500 (Thu, 28 Jan 2010) | 5 lines Remove "magic number" in the conversion of Url::SupportedScheme.Matches() into a Url::Scheme value by explicating the computation that is involved. Make Url::schemeName() static, as it does not reference a Url object. ........ r17842 | dworley | 2010-01-28 22:07:02 -0500 (Thu, 28 Jan 2010) | 3 lines Add some further test cases of name-addrs with field-parameters that contain commas. ........ Modified: * main/ <http://code.sipfoundry.org//browse/sipXecs/main/?r1=18586&r2=18587> * main/sipXcallLib/src/cp/CallManager.cpp <http://code.sipfoundry.org//browse/sipXecs/main/sipXcallLib/src/cp/CallManager.cpp?r1=18586&r2=18587> * main/sipXproxy/lib/authplugins/CallerAlias.cpp <http://code.sipfoundry.org//browse/sipXecs/main/sipXproxy/lib/authplugins/CallerAlias.cpp?r1=18586&r2=18587> * main/sipXtackLib/include/net/Url.h <http://code.sipfoundry.org//browse/sipXecs/main/sipXtackLib/include/net/Url.h?r1=18586&r2=18587> * main/sipXtackLib/src/net/Url.cpp <http://code.sipfoundry.org//browse/sipXecs/main/sipXtackLib/src/net/Url.cpp?r1=18586&r2=18587> * main/sipXtackLib/src/test/net/UrlTest.cpp <http://code.sipfoundry.org//browse/sipXecs/main/sipXtackLib/src/test/net/UrlTest.cpp?r1=18586&r2=18587> _______________________________________________ sipx-dev mailing list [email protected] List Archive: http://list.sipfoundry.org/archive/sipx-dev Unsubscribe: http://list.sipfoundry.org/mailman/listinfo/sipx-dev sipXecs IP PBX -- http://www.sipfoundry.org/
