Hello,
On 12/15/06, Andrzej Ciarkowski <[EMAIL PROTECTED]> wrote:
> I already have a running implementation of iLBC in sipXtapi, I was
> planning to contribute it in a few days.
Great :)
BTW, please, regard coding style. It usually takes much time to correct
style, much easier to follow this rules from the ground.
Most missed rules of sipXtapi projects are:
1) Indent of the new code MUST follow indent style of surrounding code.
In most cases it is three spaces, but may be four spaces too. For new
files three spaces indent SHOULD be used. Tabs MUST NOT be used
anywhere in the code. Mixing tabs and spaces totally breaks indentation.
2) Code after if's, for's, etc SHOULD be enclosed with braces, even if code
consist of one line. This style for braces SHOULD be used:
if (..)
{
}
else
{
}
3) Non-static member variables MUST begin with letter 'm'. Member pointer
variables MUST begin with letters 'mp'. Static variables MUST begin with 's'
(static member with 'sm', static member pointer with 'smp'). Global variables
MUST begin with g, and local pointer variables SHOULD use 'p' prefix.
4) Names of variables SHOULD begin with lower case letter, first letters of
following words, composing variable names SHOULD be uppercase.
E.g. mpFarAwayPointer, localVariable, pDataBuffer, etc.
5) Names of types SHOULD begin with upper case letter, first letters of
all words, composing variable names SHOULD be uppercase.
E.g. MpCodecFactory, MprFromStream, etc.
(The key words "MUST", "MUST NOT", "REQUIRED", "SHALL",
"SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED",
"MAY", and "OPTIONAL" here are to be interpreted as described
in RFC 2119.)
Hope this is not much trouble for you. :)
--
Regards,
Alexander Chemeris.
_______________________________________________
sipxtapi-dev mailing list
[email protected]
List Archive: http://list.sipfoundry.org/archive/sipxtapi-dev/
