Hi Peter,
On Mar 30, 2012, at 12:30 PM, Peter K wrote:
> Hi Chris,
>
>>> Also in L. 171 might be a bug regarding that 'capacity' thing:
>>> if (u.getCount() < this.capacity) {
>>> u.addData(data);
>> Some, would be great for another patch here :)
>
> I've raised an issue:
>
> https://issues.apache.org/jira/browse/SIS-39
Thanks a bunch!
>
> but it is hard for me to fix this properly :(
> without breaking things other places (without unit tests or in depth
> code understanding)
No problem, any contribution (even filing a JIRA issue) is a welcome asset
for us. Thanks for helping us out. I'll take a look and see if I can fix the
issues.
Also if you get time later to understand the code and submit a patch I'll
welcome
that too, but thanks for the hard work in looking at the code and filing the
issue
so far!
Cheers,
Chris
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: [email protected]
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++