Bugs item #587526, was opened at 2002-07-27 17:52
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=380273&aid=587526&group_id=24006

Category: Networking
Group: None
Status: Open
>Resolution: Fixed
Priority: 5
Submitted By: Luca Filipozzi (lfilipoz)
>Assigned to: Sean Dague (sdague)
Summary: $this->hostname invalid w/ static_dhcp

Initial Comment:
When 'getimage' is invoked with 'static_dhcp' for the
ip assignment method, the master script that is invoked
calls systemconfigurator as follows:

chroot /a/ systemconfigurator --configsi --stdin <<EOL
|| shellout
[INTERFACE0]
DEVICE = eth0
TYPE = dhcp
EOL

Unfortunately, systemconfigurator (version 1.20) fails
because $this->hostname is not valid in
Network/Interfaces.pm line 105:

104    open(OUT,">$hostfile") or croak("Couldn't open
$file for writing");
105    print OUT $this->hostname,"\n";
106    close(OUT);

and the perl script terminates.

Speaking with Dann on IRC, he believes that this is an
easy fix.

----------------------------------------------------------------------

>Comment By: Sean Dague (sdague)
Date: 2003-02-27 18:55

Message:
Logged In: YES 
user_id=21949

fixed somewhere arround 2.0

----------------------------------------------------------------------

Comment By: Sean Dague (sdague)
Date: 2002-07-27 21:39

Message:
Logged In: YES 
user_id=21949

This shouldn't be a fatal error, just a warning.  (The fatal
part here is the open if it doesn't work.)

Although the code should be fixed to get rid of the warning,
if the program exists the issue is somewhere else.

----------------------------------------------------------------------

Comment By: dann frazier (dannf)
Date: 2002-07-27 17:57

Message:
Logged In: YES 
user_id=146718

try this patch.
it looks like this code is unchanged in head, so if this
works for you 
i'll commit it there.

--- systemconfigurator-1.20.orig/lib/Network/Interfaces.pm      2001-11-02 
07:13:23.000000000 -0700
+++ systemconfigurator-1.20/lib/Network/Interfaces.pm   2002-07-27 15:50:33.000000000 
-0600
@@ -98,14 +98,15 @@
     close(OUT);
     $this->files($file);
 
-    #Now we put the hostname into /etc/hostname
-    my $hostfile = $this->chroot("/etc/hostname");
+    # If $this->hostname is defined, place it into
/etc/hostname
+    if ($this->hostname) {
+
my $hostfile = $this->chroot("/etc/hostname");
+
open(OUT,">$hostfile") or croak("Couldn't open $file for
writing");
+
print OUT $this->hostname,"\n";
+
close(OUT);
 
-    open(OUT,">$hostfile") or croak("Couldn't open $file
for writing");
-    print OUT $this->hostname,"\n";
-    close(OUT);
-
-    $this->files($file);
+
$this->files($file);
+    }
 }
 
 =item setup_interface()


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=380273&aid=587526&group_id=24006


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Sisuite-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/sisuite-devel

Reply via email to