-- 
dann frazier <[EMAIL PROTECTED]>
--- Begin Message ---
On Mon, 2005-01-17 at 15:02 -0800, [EMAIL PROTECTED]
wrote:
> lvm: $(LVM_BINARY)
> $(LVM_BINARY): $(SRC_DIR)/$(LVM_TARBALL)

The first command in this rule should be a
'rm -rf $(SRC_DIR)/$(LVM_DIR)' - if this rule needs to be re-evaluated
because of a dependency change (say a new patch is added), it will have
unexpected results otherwise.  I've noticed a few other .rul files are
missing this bit as well - tar.rul has it, that's probably a good
template to use.

>       [ -d $(SRC_DIR)/$(LVM_DIR) ] || ( cd $(SRC_DIR) && tar -xvzf 
> $(LVM_TARBALL) )
>       @cd $(SRC_DIR)/$(LVM_DIR) && \
>               ./configue --prefix=/usr --disable-nls --with-optimisation=-Os

again, why silence make here?  if something goes wrong, its nice to see
what it was doing.

dann frazier <[EMAIL PROTECTED]>

--- End Message ---

Reply via email to