Hi Andrea: Please go ahead and apply the 'fix' when you get the chance as I do not have SVN access yet.
Thanks, Bernard > -----Original Message----- > From: Andrea Righi [mailto:[EMAIL PROTECTED] > Sent: Monday, November 28, 2005 9:31 > To: Brian Elliott Finley > Cc: Bernard Li; [EMAIL PROTECTED]; > oscar-devel@lists.sourceforge.net; SIS Devel > Subject: Re: [Oscar-devel] FW: [Sisuite-devel] parted -> sfdisk change > > Bernard's solution seems the right thing... I didn't know the "unit" > option for parted, it seems it has been introduced in the > last version > only... > > Anyway (answering to Brian) is not possible to implement this > in perl, > since the `parted` command is performed at runtime, I mean, when the > autoinstallscript is running (and in this environment we've > not a perl > interpreter). So I think Bernard can commit the code as is... > > Regards, > -Andrea > > Brian Elliott Finley wrote: > > The concept looks sound. Can you modify it to be done all > in perl, then > > commit? > > > > Ie: > > $datar = `parted -s $devfs_dev print`; > > chomp $datar; > > $datar =~ s/^this//; > > $datar =~ s/that$//; > > print $out qq($datar); > > > > > > -Brian > > > > > > Thus spake Bernard Li ([EMAIL PROTECTED]): > > > >> I'm not sure if it's doing anything wrong in particular, > but I know > >> that before Andrea checked in the code with sfdisk, the line: > >> > >> print $out qq(DISK_SIZE=`parted -s $devfs_dev print ) . > q(| grep 'Disk > >> geometry for' | sed 's/^.*-//g' | sed 's/\..*$//' `) . qq(\n); > >> Will break SystemImager because the new version of parted > includes the > >> unit (eg. MB) in the output. > >> > >> Changing it to this solves that particular problem: > >> > >> print $out qq(DISK_SIZE=`parted -s $devfs_dev unit MB > print ) . q(| > >> grep 'Disk geometry for' | sed 's/^.*-//g' | sed 's/\..*$//' | sed > >> 's/MB//' `) . qq(\n); > >> > >> Cheers, > >> > >> Bernard > >> > >> ________________________________ > >> > >> From: Erich Focht [mailto:[EMAIL PROTECTED] > >> Sent: Mon 28/11/2005 00:59 > >> To: oscar-devel@lists.sourceforge.net > >> Cc: Bernard Li; SIS Devel > >> Subject: Re: [Oscar-devel] FW: [Sisuite-devel] parted -> > sfdisk change > >> > >> > >> > >> On Sunday 27 November 2005 22:44, Bernard Li wrote: > >> > >>> Can somebody with ia64 try imaging a node with > systemimager trunk? > >>> If this > >>> indeed breaks ia64 support we need to get this reverted. > >> > >> > >> There's no need to try, the switch to sfdisk does break > ia64. I actually > >> thought Brian would revert this, but maybe I misunderstood > his email. > >> > >> I'd prefer to leave this with parted instead of mixing sfdisk and > >> parted. sfdisk is just too x86 specific. Is parted doing > anything wrong? > >> > >> Regards, > >> Erich > >> > >>> For your convenience I have already built the RPMs (which > is from the > >>> latest > >>> trunk), so please test it out and let us know. > >> > >> > >>> http://www.bcgsc.ca/downloads/oscar/systemimager/ > >>> > >>> (Note, this is a _development snapshot_ of 3.5.4, not the release) > >>> > >>> Thanks, > >>> > >>> Bernard > >>> > >>> ________________________________ > >>> > >>> From: [EMAIL PROTECTED] on behalf > of Brian > >>> Elliott Finley > >>> Sent: Wed 23/11/2005 12:37 > >>> To: Andrea Righi > >>> Cc: SIS Devel > >>> Subject: [Sisuite-devel] parted -> sfdisk change > >>> > >>> > >>> > >>> I'm concerned that this change > >>> > >>> > >>> > http://svn.sisuite.org/diff.php?repname=systemimager&path=%2Ft > runk%2Flib%2FSystemImager%2FServer.pm&rev=3272&sc=1 > >>> > >>> > >>> will break things on platforms that use GPT partitioning, > such as ia64, > >>> which cannot use sfdisk. We could do a test and use sfdisk on a > >>> specific set of archs, but it would be even better if we > could patch > >>> parted to "do the right thing". > >>> > >>> I had discussions with the author of parted back when I added the > >>> GPT/ia64 support to SystemImager, and I think he'd be willing to > >>> consider a patch as long as it didn't break other functionality. > >>> > >>> Cheers, -Brian > >>> > >>> > >>> > >>> -- > >>> Brian Elliott Finley > >>> Mobile: 630.631.6621 > >>> > >>> > >>> ------------------------------------------------------- > >>> This SF.net email is sponsored by: Splunk Inc. Do you > grep through > >>> log files > >>> for problems? Stop! Download the new AJAX search engine > that makes > >>> searching your log files as easy as surfing the web. > DOWNLOAD SPLUNK! > >>> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click > >>> _______________________________________________ > >>> Sisuite-devel mailing list > >>> Sisuite-devel@lists.sourceforge.net > >>> https://lists.sourceforge.net/lists/listinfo/sisuite-devel > >>> > >>> > >>> > >> > >> -- > >> Dr. Erich Focht > >> Solution Architecture Group, Linux R&D > >> NEC High Performance Computing Europe > >> Hessbruehlstr. 21b, Stuttgart, Germany > >> > >> > >> > ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_idv37&alloc_id865&op=click _______________________________________________ Sisuite-devel mailing list Sisuite-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sisuite-devel
