From: Andrea Righi [mailto:[EMAIL PROTECTED]
Sent: Wed 02/08/2006 07:26
To: Bernard Li
Cc: sisuite-devel@lists.sourceforge.net
Subject: Re: [Sisuite-devel] Patch to support --image with si_prepareclient
Bernard,
my feedback and 3 comments:
1) I think
it's better to pass the image name instead of the image
directory to --image
option (see the changes in the attached patch)
2) in my image server for
a suse10 image it gets the xen kernel and
prints a lot of warning (empty
strings, etc), since the running kernel
is not the same kernel that is in the
image; I've fixed this problem
calling _choose_kernel_file( '',
"$image_dir/$image" ), as discussed on
IRC, and choosing the kernel as
following:
+ # If cannot find
kernel with name matching running version,
return the first good
one
+ if (@kernels)
{
+ foreach
my $file (@kernels)
{
+
my $kernel_release =
_get_kernel_release($file);
+
if (defined($kernel_release) and
(-d
"$image_dir/lib/modules/$kernel_release"))
{
+
return
$file;
}
+
}
}
3) in
si_prepareclient --my-modules conflicts with --image
Then all seems good,
if you've not other comments I think you can check
it in the
trunk.
Cheers,
-Andrea
Bernard Li wrote:
> The attached
patch will add a new function to si_prepareclient where you
> can pass it
the location of the image you want to search for appropriate
> kernel and
modules-dir and generate UYOK boot binaries from - handy to
> run on image
server where all your images are.
>
>
Thanks,
>
> Bernard
------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________ Sisuite-devel mailing list Sisuite-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sisuite-devel
