Bugs item #1767368, was opened at 2007-08-04 01:12
Message generated for change (Comment added) made by righiandr
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100259&aid=1767368&group_id=259

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: systemimager-server
Group: v3.8.1
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Andrea Righi (righiandr)
Summary: si_getimage does not send __cloning_complete__ w/ rsync/ssh

Initial Comment:
si_getimage fails to send __cloning_completed__ when you are using rsync over 
ssh.

The fault seems to be withing si_getimage perl script (/usr/sbin/si_getimage) 
line 453:

system('rsync ' . $source_host . '::' . 
$SystemImager::Common::rsync_magic_string . '>/dev/null 2>&1');


Previous lines for rsync are using $options to setup the rsync line like the 
following (line 440):

    open (RSYNC, "rsync -aHSv --numeric-ids $options |");

The important line that sets $options (for this issue, that is) is as follows 
(line 432):

  $options = $options . " rsync://${source_host}:${port}/root/ $imagedir/";


The options line is specifying the port to use when connecting.  This port is 
setup by si_prepareclient on the client side.  If rsync does not have the port 
specified, then after ssh'ing to the client, it will launch rsync bypassing the 
rsync launched by si_preparclient and not log to the file in /tmp/file?????.  
If the magic string does not get logged into the proper log file, 
si_prepareclient does not properly close rsync.

My testing involved replacing line 453 with the following:
system('rsync ' . ' -e ssh -aHSv  rsync://root@<Hard coded IP>:873/' . 
$SystemImager::Common::rsync_magic_string . '>/dev/null 2>&1');

Of course the '<Hard coded IP>' is replaced with the real IP.  With this test, 
I verified that rsync closed out on the client side properly.


-Dustin Kamper
[EMAIL PROTECTED]

----------------------------------------------------------------------

>Comment By: Andrea Righi (righiandr)
Date: 2007-08-04 13:04

Message:
Logged In: YES 
user_id=696767
Originator: NO

Could you check if the following patch fixes as well?

Thanks,
-Andrea
File Added: si_getimage-rsync-over-ssh-completion-fix.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100259&aid=1767368&group_id=259

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
sisuite-devel mailing list
sisuite-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sisuite-devel

Reply via email to