Hi Andrea,
both patches look good. I applied the one for systemconfigurator and
will tag a new version.
I'm not sure the rewrite in systemimager is needed at all, but if you
thinks so... I'd rather try getting the autoinstallscript generated correctly.
Thanks,
best regards,
Erich
On Friday 09 November 2007 23:21, Andrea Righi wrote:
> Andrea Righi wrote:
> > What do you think about the following patch (untested)? the meaningful
> > part is in lib/SystemImager/Server.pm that creates the piece of code in
> > the auto-install script that change disk names in systemconfig.conf.
> [snip]
>
> Moreover, in part correlated to this problem, systemconfigurator should
> be to accept ROOTDEV and BOOTDEV in the UUID or LABEL form.
>
> For ROOTDEV the following patch (this one is obviously for
> systemconfigurator) should be enough (at least for GRUB), *but* for
> BOOTDEV systemconfigurator should be able to:
>
> 1) resolve the UUID or LABEL into the corresponding device partition
> 2) remove the partition number to get the disk name.
>
> Is there something similar already implemented? I didn't look closely
> at the source code, too tired to do that tonight... ;-)
>
> -Andrea
>
> Index: lib/SCConfig.pm
> ===================================================================
> --- lib/SCConfig.pm (revision 704)
> +++ lib/SCConfig.pm (working copy)
> @@ -285,15 +285,19 @@
> my $boot_rootdev = $config->get('boot_rootdev');
> my $boot_bootdev = $config->get('boot_bootdev');
>
> - if ( $boot_rootdev && ! -e $boot_rootdev ) {
> - print("ROOTDEV $boot_rootdev under [BOOT] does not exist, please check
> your systemconfigurator config\n");
> - exit 1;
> + unless ( ($boot_rootdev) && ($boot_rootdev =~ /^UUID|^LABEL/) ) {
> + if ( $boot_rootdev && ! -e $boot_rootdev ) {
> + print("ROOTDEV $boot_rootdev under [BOOT] does not exist, please
> check your systemconfigurator config\n");
> + exit 1;
> + }
> }
>
> - if ( $boot_bootdev && ! -e $boot_bootdev ) {
> - print("BOOTDEV $boot_bootdev under [BOOT] does not exist, please check
> your systemconfigurator config\n");
> - exit 1;
> - }
> + unless ( ($boot_bootdev) && ($boot_bootdev =~ /^UUID|^LABEL/) ) {
> + if ( $boot_bootdev && ! -e $boot_bootdev ) {
> + print("BOOTDEV $boot_bootdev under [BOOT] does not exist, please
> check your systemconfigurator config\n");
> + exit 1;
> + }
> + }
>
> for (my $i = 0; $i < $number; $i++) {
> my $var = "kernel$i"."_path";
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
sisuite-devel mailing list
sisuite-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sisuite-devel
