Ah ok, I missed that ifdef for 2_6, makes perfect sense now.
That fix seems ok too, but I would just assume implement the fix in
platform.h, as it is in the newer versions of busy box... Makes no
difference to me really though, I'm just glad to have a solution to this.
On Wednesday 02 August 2006 10:41, Andrea Righi wrote:
> OK, I understand BB_LITTLE_ENDIAN is never defined so ELFDATAM is always
> ELFDATA2MSB = 2, right?
>
> With 2.6 kernels it works because it never executes obj_load() and uses
> insmod_ng_main() instead:
>
> #ifdef CONFIG_FEATURE_2_6_MODULES
> if (k_version > 4)
> {
> optind--;
> argv[optind + 1] = m_filename;
> return insmod_ng_main(argc - optind, argv + optind);
> }
> #endif
>
> if ((f = obj_load(fp, LOADBITS)) == NULL)
> bb_perror_msg_and_die("Could not load the module");
>
> So I think we can replace the check:
>
> #if BB_LITTLE_ENDIAN
> # define ELFDATAM ELFDATA2LSB
> #else
> # define ELFDATAM ELFDATA2LSB
> #endif
>
> into:
>
> #if __BYTE_ORDER == __LITTLE_ENDIAN
> # define ELFDATAM ELFDATA2LSB
> #else
> # define ELFDATAM ELFDATA2LSB
> #endif
>
> This should fix, then when we'll move to the next busybox version the
> problem will be automatically fixed. What do you think?
>
> -Andrea
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys -- and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Sisuite-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/sisuite-users
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Sisuite-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sisuite-users
