Frank Corrao wrote:
> On Tue, 16 Oct 2007, Andrea Righi wrote:
>
>> Frank Corrao wrote:
>>> Andrea,
>>>
>>> I think your patch will work just fine for my needs, though perhaps some
>>> folks might like the ability to define logical volume size by extents.
>>> Here is a patch against 3.8.2 - let me know what you think.
>>>
>>> Frank
>>>
>> Frank,
>>
>> your patch seems fine. I've two comments before cheking it in the
>> official trunk on svn:
>>
>> 1) I would check when the size is defined both in extents and in bytes
>> and in this case print at least a warning, for example something like:
>>
>> if (defined($lv->{size}) && defined($lv->{extent})) {
>> print "WARNING: size defined in bytes and extents for $lv_name: using the
>> size in bytes\n";
>> $lv_size = $lv->{size};
>> }
>>
>> 2) could you post the patch again without the line wrapping? it's quite
>> difficult to apply a patch that is not properly formatted (actually it's
>> broken for the patch command).
>>
>> Thanks,
>> -Andrea
>
> Andrea,
>
> Here is the updated patch:
Very good, Frank! Could you also add a brief description of the new "extent"
option in doc/man/autoinstallscript.conf.content.sgml and include this
description in the patch?
After this your patch is perfect to be checked in the turnk. BTW is it ok for
you to be added in the CREDITS file (see the patch below)?
Thanks,
-Andrea
Index: CREDITS
===================================================================
--- CREDITS (revision 4299)
+++ CREDITS (working copy)
@@ -50,6 +50,10 @@
D: bug fix for ssh (libnss_files dependency)
D: added --arch option to si_mkbootpackage
+N: Frank Corrao
+E: [EMAIL PROTECTED]
+D: patch to specify LVM volume size in extents
+
N: Sean Dague
E: [EMAIL PROTECTED]
W: http://systemconfig.sourceforge.net
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
sisuite-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sisuite-users
