On Mon, Apr 11, 2011 at 12:31:12PM -0700, Bernard Li wrote:
> You probably need this patch too:
exactly; this one supersedes my previous hack.
Using your both patches from today works perfectly fine on OpenSUSE 11.3.
Thanks !
thomas
>
> Index: lib/SystemImager/Common.pm
> ===================================================================
> --- lib/SystemImager/Common.pm (revision 4539)
> +++ lib/SystemImager/Common.pm (working copy)
> @@ -1669,6 +1669,8 @@
> return 'udev';
> } elsif (m/\bdevfs\b/) {
> return 'devfs';
> + if ((m/\bdevtmpfs\b/) || (m/\/dev\sdevtmpfs\s/)) {
> + return 'devtmpfs';
> }
> }
> close(FILE);
>
> Cheers,
>
> Bernard
>
> On Mon, Apr 11, 2011 at 12:16 PM, Bernard Li <bern...@vanhpc.org> wrote:
> > Hi Thomas:
> >
> > Please test the following *untested* patch:
> >
> > Index: lib/SystemImager/Server.pm
> > ===================================================================
> > --- lib/SystemImager/Server.pm (revision 4539)
> > +++ lib/SystemImager/Server.pm (working copy)
> > @@ -1760,7 +1760,8 @@
> > $xml_config = XMLin($file, keyattr => { boel => "+devstyle"} );
> > if( defined($xml_config->{boel}->{devstyle})
> > && ( ("$xml_config->{boel}->{devstyle}" eq "udev" )
> > - or ("$xml_config->{boel}->{devstyle}" eq "devfs") )
> > + or ("$xml_config->{boel}->{devstyle}" eq "devfs")
> > + or ("$xml_config->{boel}->{devstyle}" eq "devtmpfs") )
> > ) {
> > $fs_by_mp{'/dev'} = "/dev";
> > }
> > @@ -2316,6 +2317,7 @@
> > # Clients should have one of the following entries in their
> > # autoinstallscript.conf file:
> > #
> > +# <boel devstyle="devtmpfs"/>
> > # <boel devstyle="udev"/>
> > # <boel devstyle="devfs"/>
> > # <boel devstyle="static"/>
> > @@ -2332,7 +2334,8 @@
> >
> > if( defined($xml_config->{boel}->{devstyle})
> > && ( ("$xml_config->{boel}->{devstyle}" eq "devfs")
> > - or ("$xml_config->{boel}->{devstyle}" eq "udev" ) )
> > + or ("$xml_config->{boel}->{devstyle}" eq "udev" )
> > + or ("$xml_config->{boel}->{devstyle}" eq "devtmpfs" ) )
> > ) {
> >
> > my $cmd = q(mount /dev /a/dev -o bind || shellout);
> >
> > This, along with your patch against lib/SystemImager/Common.pm should
> > add support for devtmpfs. Please test it out and let me know if it
> > works or not. You'll need to re-generate autoinstallscript.conf and
> > the master script respectively.
> >
> > Cheers,
> >
> > Bernard
> >
> > On Mon, Apr 11, 2011 at 11:59 AM, Thomas Zeiser
> > <thomas.zei...@rrze.uni-erlangen.de> wrote:
> >> Hi Bernard,
> >>
> >> On Fri, Apr 08, 2011 at 12:35:58PM -0700, Bernard Li wrote:
> >>> Hi Thomas:
> >>>
> >>> I'm a bit hesitant to make such a major change to add support for
> >>> devtmpfs -- does imaging work correctly if you enable UYOK?
> >>
> >> I fully understand that you hesitate. However, if the "client OS"
> >> uses devtmpfs neither UYOK nor the standard kernel will work
> >> without manually editing the image.master script because
> >> /etc/systemimager/autoinstallscript.conf will have <beol
> >> devstyle="static"/> (which is completely wrong). As a consequnce,
> >> imager.master won't get a "mount /dev /a/dev -o bin " line. Thus,
> >> /a/dev is not populated and systemconfigurator won't find the
> >> harddisk to initialize grub, etc.
> >>
> >> Thus, I highly would appreciate any fix that "recognizes" devtmpfs
> >> and maks the image.master script mount /a/dev. Or at least a big
> >> warning in the documentation that this line has be added manually.
> >> A more general alternative might be adding testing code to
> >> image.master to see if /a/dev looks reasonable populated OR mount
> >> /a/dev if not.
> >>
> >> Best,
> >>
> >> thomas
> >>
> >>> Cheers,
> >>>
> >>> Bernard
> >>>
> >>> On Fri, Apr 8, 2011 at 11:48 AM, Thomas Zeiser
> >>> <thomas.zei...@rrze.uni-erlangen.de> wrote:
> >>> > Hi Bernard,
> >>> >
> >>> > here is one more:
> >>> >
> >>> > OpenSuSE 11.3 does no longer uses devfs but devtmpfs ...
> >>> > An example of /proc/mounts
> >>> >
> >>> > rootfs / rootfs rw 0 0
> >>> > devtmpfs /dev devtmpfs
> >>> > rw,relatime,size=186100k,nr_inodes=46525,mode=755 0 0
> >>> > tmpfs /dev/shm tmpfs rw,relatime 0 0
> >>> > devpts /dev/pts devpts rw,relatime,gid=5,mode=620,ptmxmode=000 0 0
> >>> > /dev/sda2 / ext4 rw,relatime,user_xattr,acl,barrier=1,data=ordered 0 0
> >>> > proc /proc proc rw,relatime 0 0
> >>> > sysfs /sys sysfs rw,relatime 0 0
> >>> > debugfs /sys/kernel/debug debugfs rw,relatime 0 0
> >>> >
> >>> > Common.pm won't detect detect that and set "boel devstyle" to
> >>> > "standard" instead of udev (and thus not mount /a/dev).
> >>> >
> >>> >
> >>> > The attached patch extends the regular pattern. But that does not
> >>> > really solve the problem. If no-uyok is used, it's not important
> >>> > what the running system uses but what the standard kernel will
> >>> > require during install. The new standard kernel will always
> >>> > require "boel devsytle=udev" (or similar) to have /a/dev mounted
> >>> > before systemconfigurator will be called from within the
> >>> > master.script.
> >>> >
> >>> >
> >>> > Best,
> >>> >
> >>> > thomas
------------------------------------------------------------------------------
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now! http://p.sf.net/sfu/ibm-webcastpromo
_______________________________________________
sisuite-users mailing list
sisuite-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sisuite-users
