Revision: 2882
http://skim-app.svn.sourceforge.net/skim-app/?rev=2882&view=rev
Author: hofman
Date: 2007-09-10 11:22:22 -0700 (Mon, 10 Sep 2007)
Log Message:
-----------
Don't over release the data passed to the fdf parser.
Modified Paths:
--------------
trunk/SKFDFParser.m
Modified: trunk/SKFDFParser.m
===================================================================
--- trunk/SKFDFParser.m 2007-09-10 18:01:06 UTC (rev 2881)
+++ trunk/SKFDFParser.m 2007-09-10 18:22:22 UTC (rev 2882)
@@ -50,8 +50,7 @@
@implementation SKFDFParser
-static const void *getCFDataBytePointer(void *info) { return
CFDataGetBytePtr((CFDataRef)info); }
-static void releaseCFData(void *info) { CFRelease((CFDataRef)info); }
+static const void *getNSDataBytePointer(void *info) { return [(NSData *)info
bytes]; }
+ (NSArray *)noteDictionariesFromFDFData:(NSData *)data {
const char *pdfHeader = "%PDF";
@@ -64,9 +63,8 @@
[pdfData replaceBytesInRange:NSMakeRange(0, pdfHeaderLength)
withBytes:pdfHeader length:pdfHeaderLength];
- static const CGDataProviderDirectAccessCallbacks callbacks =
{&getCFDataBytePointer, NULL, NULL, &releaseCFData };
- void *info = (void *)pdfData;
- CGDataProviderRef provider = CGDataProviderCreateDirectAccess(info,
[pdfData length], &callbacks);
+ static const CGDataProviderDirectAccessCallbacks callbacks =
{&getNSDataBytePointer, NULL, NULL, NULL};
+ CGDataProviderRef provider = CGDataProviderCreateDirectAccess((void
*)pdfData, [pdfData length], &callbacks);
CGPDFDocumentRef document = CGPDFDocumentCreateWithProvider(provider);
NSMutableArray *notes = nil;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
