Revision: 3357
http://skim-app.svn.sourceforge.net/skim-app/?rev=3357&view=rev
Author: hofman
Date: 2008-01-08 16:25:51 -0800 (Tue, 08 Jan 2008)
Log Message:
-----------
Fix genstrings complaints about invalid string literals and display warnings
from genstrings.
Modified Paths:
--------------
trunk/BDSKZoomablePDFView.m
trunk/SKSecondaryPDFView.m
trunk/Skim.xcodeproj/project.pbxproj
Modified: trunk/BDSKZoomablePDFView.m
===================================================================
--- trunk/BDSKZoomablePDFView.m 2008-01-08 10:26:56 UTC (rev 3356)
+++ trunk/BDSKZoomablePDFView.m 2008-01-09 00:25:51 UTC (rev 3357)
@@ -122,7 +122,7 @@
// fill it
for (cnt = 0; cnt < numberOfDefaultItems; cnt++) {
- label =
NSLocalizedStringFromTable(BDSKDefaultScaleMenuLabels[cnt], @"ZoomValues", nil);
+ label = [[NSBundle mainBundle]
localizedStringForKey:BDSKDefaultScaleMenuLabels[cnt] value:@""
table:@"ZoomValues"];
width = NSWidth([label boundingRectWithSize:size options:0
attributes:attrs]);
if (width > maxWidth) {
maxWidth = width;
Modified: trunk/SKSecondaryPDFView.m
===================================================================
--- trunk/SKSecondaryPDFView.m 2008-01-08 10:26:56 UTC (rev 3356)
+++ trunk/SKSecondaryPDFView.m 2008-01-09 00:25:51 UTC (rev 3357)
@@ -173,7 +173,7 @@
// fill it
for (cnt = 0; cnt < numberOfDefaultItems; cnt++) {
- label = NSLocalizedStringFromTable(SKDefaultScaleMenuLabels[cnt],
@"ZoomValues", nil);
+ label = [[NSBundle mainBundle]
localizedStringForKey:BDSKDefaultScaleMenuLabels[cnt] value:@""
table:@"ZoomValues"];
width = NSWidth([label boundingRectWithSize:size options:0
attributes:attrs]);
if (width > maxWidth) {
maxWidth = width;
Modified: trunk/Skim.xcodeproj/project.pbxproj
===================================================================
--- trunk/Skim.xcodeproj/project.pbxproj 2008-01-08 10:26:56 UTC (rev
3356)
+++ trunk/Skim.xcodeproj/project.pbxproj 2008-01-09 00:25:51 UTC (rev
3357)
@@ -1674,7 +1674,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "#\n# Run the genstrings build phase\n#
This takes a while to generate, so it's not worth\n# the wait for development
builds.\n#\nif [ ${BUILD_STYLE} = \"Debug\" ]; then\n# Check to see if a
previous version exists and create it\n# if not, or else pbxcp will
complain.\nif [ -f \"English.lproj/Localizable.strings\" ]; then\nexit
0\nfi\n#\n# Run the genstrings build phase\n#\nfi\ncd ${SOURCE_ROOT}\nif [ -f
\"English.lproj/Localizable.strings\" ]; then\nmv
English.lproj/Localizable.strings English.lproj/Localizable.strings.bak
\nfi\n/usr/bin/genstrings -o ${SOURCE_ROOT}/English.lproj *.m";
+ shellScript = "#\n# Run the genstrings build phase\n#
This takes a while to generate, so it's not worth\n# the wait for development
builds.\n#\nif [ ${BUILD_STYLE} = \"Debug\" ]; then\n# Check to see if a
previous version exists and create it\n# if not, or else pbxcp will
complain.\nif [ -f \"English.lproj/Localizable.strings\" ]; then\nexit
0\nfi\n#\n# Run the genstrings build phase\n#\nfi\ncd ${SOURCE_ROOT}\nif [ -f
\"English.lproj/Localizable.strings\" ]; then\nmv
English.lproj/Localizable.strings English.lproj/Localizable.strings.bak
\nfi\n\n/usr/bin/genstrings -o ${SOURCE_ROOT}/English.lproj *.m 2>&1 | sed -e
's/^.*Warning:/warning:/g' >&2\n";
};
CEE22EA50BFB8691002B746B /* ShellScript */ = {
isa = PBXShellScriptBuildPhase;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
