Revision: 4345
http://skim-app.svn.sourceforge.net/skim-app/?rev=4345&view=rev
Author: hofman
Date: 2008-08-04 10:03:16 +0000 (Mon, 04 Aug 2008)
Log Message:
-----------
Don't bother returning a shared EA manager from the initializers. Shared
instances should be accessed by their designated class methods. The
initializers should not be used anyway, and there is no use for EA managers in
a nib.
Modified Paths:
--------------
trunk/SkimNotes/SKNExtendedAttributeManager.m
Modified: trunk/SkimNotes/SKNExtendedAttributeManager.m
===================================================================
--- trunk/SkimNotes/SKNExtendedAttributeManager.m 2008-08-04 00:32:30 UTC
(rev 4344)
+++ trunk/SkimNotes/SKNExtendedAttributeManager.m 2008-08-04 10:03:16 UTC
(rev 4345)
@@ -76,31 +76,16 @@
- (id)init;
{
- self = [self initWithPrefix:PREFIX];
- if (sharedManager) {
- [self release];
- self = [sharedManager retain];
- } else {
- sharedManager = [self retain]; // we don't care about overretaining a
shared object, but we care about overreleasing
- }
- return self;
+ return [self initWithPrefix:PREFIX];
}
- (id)initWithPrefix:(NSString *)prefix;
{
if (self = [super init]) {
- if (prefix) {
- namePrefix = [[prefix stringByAppendingString:NAME_SEPARATOR]
retain];
- uniqueKey = [[prefix stringByAppendingString:UNIQUE_KEY_SUFFIX]
retain];
- wrapperKey = [[prefix stringByAppendingString:WRAPPER_KEY_SUFFIX]
retain];
- fragmentsKey = [[prefix
stringByAppendingString:FRAGMENTS_KEY_SUFFIX] retain];
- } else if (sharedNoSplitManager) {
- [self release];
- self = [sharedNoSplitManager retain];
- } else {
- namePrefix = uniqueKey = wrapperKey = fragmentsKey = nil;
- sharedNoSplitManager = [self retain]; // we don't care about
overretaining a shared object, but we care about overreleasing
- }
+ namePrefix = [[prefix stringByAppendingString:NAME_SEPARATOR] retain];
+ uniqueKey = [[prefix stringByAppendingString:UNIQUE_KEY_SUFFIX]
retain];
+ wrapperKey = [[prefix stringByAppendingString:WRAPPER_KEY_SUFFIX]
retain];
+ fragmentsKey = [[prefix stringByAppendingString:FRAGMENTS_KEY_SUFFIX]
retain];
}
return self;
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
