Revision: 4378
http://skim-app.svn.sourceforge.net/skim-app/?rev=4378&view=rev
Author: hofman
Date: 2008-08-11 20:55:05 +0000 (Mon, 11 Aug 2008)
Log Message:
-----------
rename method argument to reflect the meaning rather than the implementation
Modified Paths:
--------------
trunk/SKPDFDocument.m
trunk/SKPDFSynchronizer.h
trunk/SKPDFSynchronizer.m
Modified: trunk/SKPDFDocument.m
===================================================================
--- trunk/SKPDFDocument.m 2008-08-11 20:11:06 UTC (rev 4377)
+++ trunk/SKPDFDocument.m 2008-08-11 20:55:05 UTC (rev 4378)
@@ -1494,9 +1494,9 @@
}
}
-- (void)synchronizer:(SKPDFSynchronizer *)synchronizer
foundLocation:(NSPoint)point atPageIndex:(unsigned int)pageIndex
isSyncTeX:(BOOL)isSyncTeX {
+- (void)synchronizer:(SKPDFSynchronizer *)synchronizer
foundLocation:(NSPoint)point atPageIndex:(unsigned int)pageIndex
isFlipped:(BOOL)isFlipped {
PDFPage *page = [[self pdfDocument] pageAtIndex:pageIndex];
- if (isSyncTeX)
+ if (isFlipped)
point.y = NSMaxY([page boundsForBox:kPDFDisplayBoxMediaBox]) - point.y;
if ([[NSUserDefaults standardUserDefaults]
boolForKey:SKShouldHighlightSearchResultsKey])
[[self mainWindowController] addTemporaryAnnotationForPoint:point
onPage:page];
Modified: trunk/SKPDFSynchronizer.h
===================================================================
--- trunk/SKPDFSynchronizer.h 2008-08-11 20:11:06 UTC (rev 4377)
+++ trunk/SKPDFSynchronizer.h 2008-08-11 20:55:05 UTC (rev 4378)
@@ -78,5 +78,5 @@
@interface NSObject (SKPDFSynchronizerDelegate)
- (void)synchronizer:(SKPDFSynchronizer *)synchronizer foundLine:(int)line
inFile:(NSString *)file;
-- (void)synchronizer:(SKPDFSynchronizer *)synchronizer
foundLocation:(NSPoint)point atPageIndex:(unsigned int)pageIndex
isSyncTeX:(BOOL)isSyncTeX;
+- (void)synchronizer:(SKPDFSynchronizer *)synchronizer
foundLocation:(NSPoint)point atPageIndex:(unsigned int)pageIndex
isFlipped:(BOOL)isFlipped;
@end
Modified: trunk/SKPDFSynchronizer.m
===================================================================
--- trunk/SKPDFSynchronizer.m 2008-08-11 20:11:06 UTC (rev 4377)
+++ trunk/SKPDFSynchronizer.m 2008-08-11 20:55:05 UTC (rev 4378)
@@ -76,7 +76,7 @@
@protocol SKPDFSynchronizerMainThread
- (void)setLocalServer:(byref id)anObject;
- (oneway void)serverFoundLine:(int)line inFile:(bycopy NSString *)file;
-- (oneway void)serverFoundLocation:(NSPoint)point atPageIndex:(unsigned
int)pageIndex isSyncTeX:(BOOL)isSyncTeX;
+- (oneway void)serverFoundLocation:(NSPoint)point atPageIndex:(unsigned
int)pageIndex isFlipped:(BOOL)isFlipped;
@end
#pragma mark -
@@ -326,9 +326,9 @@
[delegate synchronizer:self foundLine:line inFile:file];
}
-- (oneway void)serverFoundLocation:(NSPoint)point atPageIndex:(unsigned
int)pageIndex isSyncTeX:(BOOL)isSyncTeX {
- if ([self shouldKeepRunning] && [delegate
respondsToSelector:@selector(synchronizer:foundLocation:atPageIndex:isSyncTeX:)])
- [delegate synchronizer:self foundLocation:point atPageIndex:pageIndex
isSyncTeX:isSyncTeX];
+- (oneway void)serverFoundLocation:(NSPoint)point atPageIndex:(unsigned
int)pageIndex isFlipped:(BOOL)isFlipped {
+ if ([self shouldKeepRunning] && [delegate
respondsToSelector:@selector(synchronizer:foundLocation:atPageIndex:isFlipped:)])
+ [delegate synchronizer:self foundLocation:point atPageIndex:pageIndex
isFlipped:isFlipped];
}
#pragma mark | Server thread
@@ -670,7 +670,7 @@
success = [self synctexFindPage:&foundPageIndex
location:&foundPoint forLine:line inFile:file];
if (success && [self shouldKeepRunning])
- [serverOnMainThread serverFoundLocation:foundPoint
atPageIndex:foundPageIndex isSyncTeX:isPdfsync == NO];
+ [serverOnMainThread serverFoundLocation:foundPoint
atPageIndex:foundPageIndex isFlipped:isPdfsync == NO];
}
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
