Revision: 4564
http://skim-app.svn.sourceforge.net/skim-app/?rev=4564&view=rev
Author: hofman
Date: 2008-09-05 18:01:01 +0000 (Fri, 05 Sep 2008)
Log Message:
-----------
Rename "logical" page numbering to "sequential" page numbering, as I got it
wrong due to the RFE's formulation.
Modified Paths:
--------------
trunk/PDFPage_SKExtensions.h
trunk/PDFPage_SKExtensions.m
trunk/SKMainWindowController.m
trunk/SKStringConstants.h
trunk/SKStringConstants.m
Modified: trunk/PDFPage_SKExtensions.h
===================================================================
--- trunk/PDFPage_SKExtensions.h 2008-09-05 17:01:11 UTC (rev 4563)
+++ trunk/PDFPage_SKExtensions.h 2008-09-05 18:01:01 UTC (rev 4564)
@@ -51,8 +51,8 @@
@interface PDFPage (SKExtensions)
-+ (BOOL)usesLogicalPageNumbering;
-+ (void)setUsesLogicalPageNumbering:(BOOL)flag;
++ (BOOL)usesSequentialPageNumbering;
++ (void)setUsesSequentialPageNumbering:(BOOL)flag;
- (NSRect)foregroundBox;
- (NSImage *)image;
Modified: trunk/PDFPage_SKExtensions.m
===================================================================
--- trunk/PDFPage_SKExtensions.m 2008-09-05 17:01:11 UTC (rev 4563)
+++ trunk/PDFPage_SKExtensions.m 2008-09-05 18:01:01 UTC (rev 4564)
@@ -79,14 +79,14 @@
bboxCache = CFDictionaryCreateMutable(NULL, 0, NULL,
&kSKNSRectDictionaryValueCallBacks);
}
-static BOOL usesLogicalPageNumbering = NO;
+static BOOL usesSequentialPageNumbering = NO;
-+ (BOOL)usesLogicalPageNumbering {
- return usesLogicalPageNumbering;
++ (BOOL)usesSequentialPageNumbering {
+ return usesSequentialPageNumbering;
}
-+ (void)setUsesLogicalPageNumbering:(BOOL)flag {
- usesLogicalPageNumbering = flag;
++ (void)setUsesSequentialPageNumbering:(BOOL)flag {
+ usesSequentialPageNumbering = flag;
}
// mainly useful for drawing the box in a PDFView while debugging
@@ -341,7 +341,7 @@
- (NSString *)displayLabel {
NSString *label = nil;
- if ([[self class] usesLogicalPageNumbering] == NO)
+ if ([[self class] usesSequentialPageNumbering] == NO)
label = [self label];
return label ?: [self logicalLabel];
}
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2008-09-05 17:01:11 UTC (rev 4563)
+++ trunk/SKMainWindowController.m 2008-09-05 18:01:01 UTC (rev 4564)
@@ -217,7 +217,7 @@
segmentedControlOffset = 0.0;
}
- [PDFPage setUsesLogicalPageNumbering:[[NSUserDefaults
standardUserDefaults] boolForKey:SKLogicalPageNumberingKey]];
+ [PDFPage setUsesSequentialPageNumbering:[[NSUserDefaults
standardUserDefaults] boolForKey:SKSequentialPageNumberingKey]];
}
+ (BOOL)automaticallyNotifiesObserversForKey:(NSString *)key {
@@ -3263,7 +3263,7 @@
SKSearchHighlightColorKey,
SKShouldHighlightSearchResultsKey,
SKThumbnailSizeKey,
SKSnapshotThumbnailSizeKey,
SKShouldAntiAliasKey,
SKGreekingThresholdKey,
- SKTableFontSizeKey,
SKLogicalPageNumberingKey, nil]
+ SKTableFontSizeKey,
SKSequentialPageNumberingKey, nil]
context:SKMainWindowDefaultsObservationContext];
}
@@ -3273,7 +3273,7 @@
SKSearchHighlightColorKey,
SKShouldHighlightSearchResultsKey,
SKThumbnailSizeKey,
SKSnapshotThumbnailSizeKey,
SKShouldAntiAliasKey,
SKGreekingThresholdKey,
- SKTableFontSizeKey,
SKLogicalPageNumberingKey, nil]];
+ SKTableFontSizeKey,
SKSequentialPageNumberingKey, nil]];
}
#pragma mark Undo
@@ -3380,8 +3380,8 @@
[findTableView setFont:font];
[groupedFindTableView setFont:font];
[self updatePageColumnWidthForTableView:outlineView];
- } else if ([key isEqualToString:SKLogicalPageNumberingKey]) {
- [PDFPage setUsesLogicalPageNumbering:[[NSUserDefaults
standardUserDefaults] boolForKey:SKLogicalPageNumberingKey]];
+ } else if ([key isEqualToString:SKSequentialPageNumberingKey]) {
+ [PDFPage setUsesSequentialPageNumbering:[[NSUserDefaults
standardUserDefaults] boolForKey:SKSequentialPageNumberingKey]];
[self updatePageLabelsAndOutline];
}
Modified: trunk/SKStringConstants.h
===================================================================
--- trunk/SKStringConstants.h 2008-09-05 17:01:11 UTC (rev 4563)
+++ trunk/SKStringConstants.h 2008-09-05 18:01:01 UTC (rev 4564)
@@ -114,4 +114,4 @@
extern NSString *SKAutoCloseDownloadsWindowKey;
extern NSString *SKShouldSetCreatorCodeKey;
extern NSString *SKTableFontSizeKey;
-extern NSString *SKLogicalPageNumberingKey;
+extern NSString *SKSequentialPageNumberingKey;
Modified: trunk/SKStringConstants.m
===================================================================
--- trunk/SKStringConstants.m 2008-09-05 17:01:11 UTC (rev 4563)
+++ trunk/SKStringConstants.m 2008-09-05 18:01:01 UTC (rev 4564)
@@ -115,4 +115,4 @@
NSString *SKAutoCloseDownloadsWindowKey = @"SKAutoCloseDownloadsWindow";
NSString *SKShouldSetCreatorCodeKey = @"SKShouldSetCreatorCode";
NSString *SKTableFontSizeKey = @"SKTableFontSize";
-NSString *SKLogicalPageNumberingKey = @"SKLogicalPageNumbering";
+NSString *SKSequentialPageNumberingKey = @"SKSequentialPageNumbering";
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
