Revision: 4785
          http://skim-app.svn.sourceforge.net/skim-app/?rev=4785&view=rev
Author:   hofman
Date:     2008-10-13 15:08:08 +0000 (Mon, 13 Oct 2008)

Log Message:
-----------
Don't write skim notes to temporary file for atomic save, as this can overwrite 
the notes in the target location, so we don't know which fragment attributes to 
remove.

Modified Paths:
--------------
    trunk/SKPDFDocument.m

Modified: trunk/SKPDFDocument.m
===================================================================
--- trunk/SKPDFDocument.m       2008-10-13 14:40:01 UTC (rev 4784)
+++ trunk/SKPDFDocument.m       2008-10-13 15:08:08 UTC (rev 4785)
@@ -418,10 +418,6 @@
         didWrite = [pdfData writeToURL:absoluteURL options:0 error:&error];
     } else if (SKIsPDFDocumentType(typeName)) {
         didWrite = [pdfData writeToURL:absoluteURL options:0 error:&error];
-        // notes are only saved as a dry-run to test if we can write, they are 
not copied to the final destination. 
-        // if we automatically save a .skim backup we silently ignore this 
problem
-        if (didWrite && NO == [[NSUserDefaults standardUserDefaults] 
boolForKey:SKAutoSaveSkimNotesKey])
-            didWrite = [[NSFileManager defaultManager] writeSkimNotes:[[self 
notes] valueForKey:@"SkimNoteProperties"] textNotes:[self notesString] 
richTextNotes:[self notesRTFData] toExtendedAttributesAtURL:absoluteURL 
error:&error];
     } else if (SKIsPDFBundleDocumentType(typeName)) {
         NSString *name = [[[absoluteURL path] lastPathComponent] 
stringByDeletingPathExtension];
         if ([name caseInsensitiveCompare:BUNDLE_DATA_FILENAME] == 
NSOrderedSame)


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to