Revision: 5089
          http://skim-app.svn.sourceforge.net/skim-app/?rev=5089&view=rev
Author:   hofman
Date:     2008-12-23 17:46:56 +0000 (Tue, 23 Dec 2008)

Log Message:
-----------
Avoid a leak when reading fails partially

Modified Paths:
--------------
    trunk/SKPDFDocument.m

Modified: trunk/SKPDFDocument.m
===================================================================
--- trunk/SKPDFDocument.m       2008-12-23 13:44:35 UTC (rev 5088)
+++ trunk/SKPDFDocument.m       2008-12-23 17:46:56 UTC (rev 5089)
@@ -726,13 +726,13 @@
             [self setPDFData:data];
             [self setPDFDoc:pdfDoc];
             [pdfDoc release];
-            [data release];
             fileChangedOnDisk = NO;
             [lastModifiedDate release];
             lastModifiedDate = [[[[NSFileManager defaultManager] 
fileAttributesAtPath:[absoluteURL path] traverseLink:YES] fileModificationDate] 
retain];
         } else {
             [self setPDFData:nil];
         }
+        [data release];
     }
     
     if (didRead == NO && outError != NULL)


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to