Revision: 5176
          http://skim-app.svn.sourceforge.net/skim-app/?rev=5176&view=rev
Author:   hofman
Date:     2009-01-28 11:04:58 +0000 (Wed, 28 Jan 2009)

Log Message:
-----------
no need to retain the task for dvi conversion as it's only used locally

Modified Paths:
--------------
    trunk/SKConversionProgressController.m

Modified: trunk/SKConversionProgressController.m
===================================================================
--- trunk/SKConversionProgressController.m      2009-01-27 23:00:09 UTC (rev 
5175)
+++ trunk/SKConversionProgressController.m      2009-01-28 11:04:58 UTC (rev 
5176)
@@ -375,9 +375,7 @@
     NSInvocation *invocation;
     
     if (SKFileExistsAtPath(dviFile) && [self shouldKeepRunning]) {
-        
-        NSTask *task = [[NSTask launchedTaskWithLaunchPath:commandPath 
arguments:arguments currentDirectoryPath:[dviFile 
stringByDeletingLastPathComponent]] retain];
-        
+        NSTask *task = [NSTask launchedTaskWithLaunchPath:commandPath 
arguments:arguments currentDirectoryPath:[dviFile 
stringByDeletingLastPathComponent]];
         if (task) {
             invocation = [NSInvocation invocationWithTarget:self 
selector:@selector(conversionStarted)];
             [invocation performSelectorOnMainThread:@selector(invoke) 
withObject:nil waitUntilDone:NO];
@@ -389,8 +387,6 @@
             else if ([self shouldKeepRunning])
                 success = ([task terminationStatus] == 0);
         }
-        
-        [task release];
     }
     
     NSData *outData = success ? [NSData dataWithContentsOfFile:outFile] : nil;


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to