Revision: 5487
          http://skim-app.svn.sourceforge.net/skim-app/?rev=5487&view=rev
Author:   hofman
Date:     2009-07-15 23:04:31 +0000 (Wed, 15 Jul 2009)

Log Message:
-----------
Fix some XML and URL escape issues in appcasts

Modified Paths:
--------------
    trunk/vendorsrc/andymatuschak/Sparkle/SUAppcast.m
    trunk/vendorsrc/andymatuschak/Sparkle/SUAppcastItem.m

Modified: trunk/vendorsrc/andymatuschak/Sparkle/SUAppcast.m
===================================================================
--- trunk/vendorsrc/andymatuschak/Sparkle/SUAppcast.m   2009-07-15 14:47:05 UTC 
(rev 5486)
+++ trunk/vendorsrc/andymatuschak/Sparkle/SUAppcast.m   2009-07-15 23:04:31 UTC 
(rev 5487)
@@ -132,6 +132,11 @@
                                        if (date)
                                                [dict setObject:date 
forKey:name];
                                }
+                else if ([name isEqualToString:@"description"])
+                {
+                                       // may need XML representation for 
display in release notes
+                                       [dict setObject:[node XMLString] 
forKey:name];
+                               }
                 else if (name != nil)
                 {
                                        // add all other values as strings

Modified: trunk/vendorsrc/andymatuschak/Sparkle/SUAppcastItem.m
===================================================================
--- trunk/vendorsrc/andymatuschak/Sparkle/SUAppcastItem.m       2009-07-15 
14:47:05 UTC (rev 5486)
+++ trunk/vendorsrc/andymatuschak/Sparkle/SUAppcastItem.m       2009-07-15 
23:04:31 UTC (rev 5487)
@@ -138,7 +138,11 @@
             [self setDate:[dict objectForKey:@"pubDate"]];
             [self setItemDescription:[dict objectForKey:@"description"]];
             
-            [self setFileURL:[NSURL URLWithString:[[enclosure 
objectForKey:@"url"] 
stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]]];
+            NSString *URLString = [enclosure objectForKey:@"url"];
+            // if the string already has percent escapes, convert them to e.g. 
avoid changing %20 to %2520
+            URLString = [URLString 
stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
+            URLString = [URLString 
stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
+            [self setFileURL:[NSURL URLWithString:URLString]];
             [self setDSASignature:[enclosure 
objectForKey:@"sparkle:dsaSignature"]];           
             
             [self setVersionString:newVersion];


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to