Revision: 5545
          http://skim-app.svn.sourceforge.net/skim-app/?rev=5545&view=rev
Author:   hofman
Date:     2009-08-12 13:23:00 +0000 (Wed, 12 Aug 2009)

Log Message:
-----------
remove comments that don't apply since the docs now notes NSCopying conformance 
for PDFSelection

Modified Paths:
--------------
    trunk/PDFSelection_SKExtensions.m
    trunk/SKMainWindowController.m

Modified: trunk/PDFSelection_SKExtensions.m
===================================================================
--- trunk/PDFSelection_SKExtensions.m   2009-08-12 12:25:31 UTC (rev 5544)
+++ trunk/PDFSelection_SKExtensions.m   2009-08-12 13:23:00 UTC (rev 5545)
@@ -65,7 +65,7 @@
 }
 
 - (NSAttributedString *)contextString {
-    PDFSelection *extendedSelection = [self copy]; // see remark in 
-tableViewSelectionDidChange:
+    PDFSelection *extendedSelection = [self copy];
        NSMutableAttributedString *attributedSample;
        NSString *searchString = [self cleanedString];
        NSString *sample;

Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m      2009-08-12 12:25:31 UTC (rev 5544)
+++ trunk/SKMainWindowController.m      2009-08-12 13:23:00 UTC (rev 5545)
@@ -1910,7 +1910,7 @@
     NSEnumerator *selE = [findResults objectEnumerator];
     PDFSelection *sel;
     
-    // arm:  PDFSelection is mutable, and using -addSelection on an object 
from selectedObjects will actually mutate the object in searchResults, which 
does bad things.  MagicHat indicates that PDFSelection implements copyWithZone: 
even though it doesn't conform to <NSCopying>, so we'll use that since -init 
doesn't work (-initWithDocument: does, but it's not listed in the header 
either).  I filed rdar://problem/4888251 and also noticed that PDFKitViewer 
sample code uses -[PDFSelection copy].
+    // arm:  PDFSelection is mutable, and using -addSelection on an object 
from selectedObjects will actually mutate the object in searchResults, which 
does bad things.
     PDFSelection *firstSel = [selE nextObject];
     PDFSelection *currentSel = [[firstSel copy] autorelease];
     


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to