Revision: 6419
http://skim-app.svn.sourceforge.net/skim-app/?rev=6419&view=rev
Author: hofman
Date: 2010-04-05 12:23:03 +0000 (Mon, 05 Apr 2010)
Log Message:
-----------
declare properties with private setters in class continuation
Modified Paths:
--------------
trunk/SKDownload.h
trunk/SKDownload.m
trunk/SKSnapshotWindowController.h
trunk/SKSnapshotWindowController.m
Modified: trunk/SKDownload.h
===================================================================
--- trunk/SKDownload.h 2010-04-05 09:44:26 UTC (rev 6418)
+++ trunk/SKDownload.h 2010-04-05 12:23:03 UTC (rev 6419)
@@ -85,9 +85,9 @@
@property (nonatomic, readonly) NSURL *URL;
-...@property (nonatomic, readonly) NSString *filePath;
+...@property (nonatomic, readonly, retain) NSString *filePath;
@property (nonatomic, readonly) NSString *fileName;
-...@property (nonatomic, readonly) NSImage *fileIcon;
+...@property (nonatomic, readonly, retain) NSImage *fileIcon;
@property (nonatomic, readonly) long long expectedContentLength,
receivedContentLength;
@property (nonatomic, readonly) NSURLDownload *URLDownload;
Modified: trunk/SKDownload.m
===================================================================
--- trunk/SKDownload.m 2010-04-05 09:44:26 UTC (rev 6418)
+++ trunk/SKDownload.m 2010-04-05 12:23:03 UTC (rev 6419)
@@ -46,11 +46,11 @@
#define SKFilePathKey @"filePath"
-...@interface SKDownload (Private)
-- (void)setStatus:(SKDownloadStatus)newStatus;
-- (void)setFilePath:(NSString *)newFilePath;
-- (void)setExpectedContentLength:(long long)newExpectedContentLength;
-- (void)setReceivedContentLength:(long long)newReceivedContentLength;
+...@interface SKDownload ()
+...@property (nonatomic) SKDownloadStatus status;
+...@property (nonatomic, retain) NSString *filePath;
+...@property (nonatomic, retain) NSImage *fileIcon;
+...@property (nonatomic) long long expectedContentLength,
receivedContentLength;
- (void)handleApplicationWillTerminateNotification:(NSNotification
*)notification;
@end
@@ -172,13 +172,6 @@
return fileIcon;
}
-- (void)setFileIcon:(NSImage *)newFileIcon {
- if (fileIcon != newFileIcon) {
- [fileIcon release];
- fileIcon = [newFileIcon retain];
- }
-}
-
- (void)setExpectedContentLength:(long long)newExpectedContentLength {
if (expectedContentLength != newExpectedContentLength) {
expectedContentLength = newExpectedContentLength;
Modified: trunk/SKSnapshotWindowController.h
===================================================================
--- trunk/SKSnapshotWindowController.h 2010-04-05 09:44:26 UTC (rev 6418)
+++ trunk/SKSnapshotWindowController.h 2010-04-05 12:23:03 UTC (rev 6419)
@@ -69,7 +69,7 @@
@property (nonatomic, readonly) PDFView *pdfView;
@property (nonatomic, retain) NSImage *thumbnail;
@property (nonatomic, readonly) NSUInteger pageIndex;
-...@property (nonatomic, readonly) NSString *pageLabel;
+...@property (nonatomic, readonly, copy) NSString *pageLabel;
@property (nonatomic, readonly) BOOL hasWindow;
@property (nonatomic, readonly) NSDictionary *pageAndWindow;
@property (nonatomic, readonly) NSDictionary *currentSetup;
Modified: trunk/SKSnapshotWindowController.m
===================================================================
--- trunk/SKSnapshotWindowController.m 2010-04-05 09:44:26 UTC (rev 6418)
+++ trunk/SKSnapshotWindowController.m 2010-04-05 12:23:03 UTC (rev 6419)
@@ -70,9 +70,9 @@
static char SKSnaphotWindowDefaultsObservationContext;
-...@interface SKSnapshotWindowController (SKPrivate)
-- (void)setPageLabel:(NSString *)newPageLabel;
-- (void)setHasWindow:(BOOL)flag;
+...@interface SKSnapshotWindowController ()
+...@property (nonatomic, copy) NSString *pageLabel;
+...@property (nonatomic) BOOL hasWindow;
@end
@implementation SKSnapshotWindowController
@@ -291,10 +291,6 @@
}
}
-- (void)setHasWindow:(BOOL)flag {
- hasWindow = flag;
-}
-
- (NSDictionary *)pageAndWindow {
return [NSDictionary dictionaryWithObjectsAndKeys:[self pageLabel],
SKSnapshotPageCellLabelKey, [NSNumber numberWithBool:[self hasWindow]],
SKSnapshotPageCellHasWindowKey, nil];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit