Revision: 6881
          http://skim-app.svn.sourceforge.net/skim-app/?rev=6881&view=rev
Author:   hofman
Date:     2010-11-21 10:54:38 +0000 (Sun, 21 Nov 2010)

Log Message:
-----------
just use compare: for version numbers

Modified Paths:
--------------
    trunk/PDFAnnotation_SKExtensions.m
    trunk/SKVersionNumber.h
    trunk/SKVersionNumber.m

Modified: trunk/PDFAnnotation_SKExtensions.m
===================================================================
--- trunk/PDFAnnotation_SKExtensions.m  2010-11-09 18:18:26 UTC (rev 6880)
+++ trunk/PDFAnnotation_SKExtensions.m  2010-11-21 10:54:38 UTC (rev 6881)
@@ -104,7 +104,7 @@
     SKVersionNumber *PDFKitVersion = [[[SKVersionNumber alloc] 
initWithVersionString:[[NSBundle bundleForClass:self] 
objectForInfoDictionaryKey:(NSString *)kCFBundleVersionKey]] autorelease];
     SKVersionNumber *minVersion = [[[SKVersionNumber alloc] 
initWithVersionString:@"2.5"] autorelease];
     SKVersionNumber *maxVersion = [[[SKVersionNumber alloc] 
initWithVersionString:@"2.5.1"] autorelease];
-    if ([PDFKitVersion compareToVersionNumber:minVersion] != 
NSOrderedAscending && [PDFKitVersion compareToVersionNumber:maxVersion] != 
NSOrderedDescending)
+    if ([PDFKitVersion compare:minVersion] != NSOrderedAscending && 
[PDFKitVersion compare:maxVersion] != NSOrderedDescending)
         SKPDFAnnotationLeaksBorder = YES;
 }
 

Modified: trunk/SKVersionNumber.h
===================================================================
--- trunk/SKVersionNumber.h     2010-11-09 18:18:26 UTC (rev 6880)
+++ trunk/SKVersionNumber.h     2010-11-21 10:54:38 UTC (rev 6881)
@@ -66,6 +66,6 @@
 
 - (NSInteger)componentAtIndex:(NSUInteger)componentIndex;
 
-- (NSComparisonResult)compareToVersionNumber:(SKVersionNumber *)otherVersion;
+- (NSComparisonResult)compare:(SKVersionNumber *)otherVersion;
 
 @end

Modified: trunk/SKVersionNumber.m
===================================================================
--- trunk/SKVersionNumber.m     2010-11-09 18:18:26 UTC (rev 6880)
+++ trunk/SKVersionNumber.m     2010-11-21 10:54:38 UTC (rev 6881)
@@ -47,7 +47,7 @@
 {
     SKVersionNumber *versionNumber = [[self alloc] 
initWithVersionString:versionString];
     SKVersionNumber *otherVersionNumber = [[self alloc] 
initWithVersionString:otherVersionString];
-    NSComparisonResult result = [versionNumber 
compareToVersionNumber:otherVersionNumber];
+    NSComparisonResult result = [versionNumber compare:otherVersionNumber];
     [versionNumber release];
     [otherVersionNumber release];
     return result;
@@ -185,10 +185,10 @@
 {
     if ([otherObject isMemberOfClass:[self class]] == NO)
         return NO;
-    return [self compareToVersionNumber:(SKVersionNumber *)otherObject] == 
NSOrderedSame;
+    return [self compare:(SKVersionNumber *)otherObject] == NSOrderedSame;
 }
 
-- (NSComparisonResult)compareToVersionNumber:(SKVersionNumber *)otherVersion;
+- (NSComparisonResult)compare:(SKVersionNumber *)otherVersion;
 {
     if (otherVersion == nil)
         return NSOrderedAscending;


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to