Revision: 6900
          http://skim-app.svn.sourceforge.net/skim-app/?rev=6900&view=rev
Author:   hofman
Date:     2010-11-27 13:09:59 +0000 (Sat, 27 Nov 2010)

Log Message:
-----------
override setters rather than getters for script command overrides, as they are 
typically used only once

Modified Paths:
--------------
    trunk/NSScriptCommand_SKExtensions.m

Modified: trunk/NSScriptCommand_SKExtensions.m
===================================================================
--- trunk/NSScriptCommand_SKExtensions.m        2010-11-27 12:59:00 UTC (rev 
6899)
+++ trunk/NSScriptCommand_SKExtensions.m        2010-11-27 13:09:59 UTC (rev 
6900)
@@ -59,25 +59,23 @@
     }
 }
 
-static id (*original_receiversSpecifier)(id, SEL) = NULL;
-static id (*original_arguments)(id, SEL) = NULL;
+static void (*original_setReceiversSpecifier)(id, SEL, id) = NULL;
+static void (*original_setArguments)(id, SEL, id) = NULL;
 
-- (NSScriptObjectSpecifier *)replacement_receiversSpecifier {
-    NSScriptObjectSpecifier *specifier = original_receiversSpecifier(self, 
_cmd);
-    fixRangeSpecifier(specifier);
-    return specifier;
+- (void)replacement_setReceiversSpecifier:(NSScriptObjectSpecifier 
*)receiversSpec {
+    fixRangeSpecifier(receiversSpec);
+    original_setReceiversSpecifier(self, _cmd, receiversSpec);
 }
 
-- (NSDictionary *)replacement_arguments {
-    NSDictionary *arguments = original_arguments(self, _cmd);
-    for (NSString *key in arguments)
-        fixRangeSpecifier([arguments objectForKey:key]);
-    return arguments;
+- (void)replacement_setArguments:(NSDictionary *)args {
+    for (NSString *key in args)
+        fixRangeSpecifier([args objectForKey:key]);
+    original_setArguments(self, _cmd, args);
 }
 
 + (void)load {
-    original_receiversSpecifier = (id (*)(id, 
SEL))SKReplaceInstanceMethodImplementationFromSelector(self, 
@selector(receiversSpecifier), @selector(replacement_receiversSpecifier));
-    original_arguments = (id (*)(id, 
SEL))SKReplaceInstanceMethodImplementationFromSelector(self, 
@selector(arguments), @selector(original_arguments));
+    original_setReceiversSpecifier = (void (*)(id, SEL, 
id))SKReplaceInstanceMethodImplementationFromSelector(self, 
@selector(setReceiversSpecifier:), 
@selector(replacement_setReceiversSpecifier:));
+    original_setArguments = (void (*)(id, SEL, 
id))SKReplaceInstanceMethodImplementationFromSelector(self, 
@selector(setArguments:), @selector(original_setArguments:));
 }
 
 @end


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to