Revision: 6959
          http://skim-app.svn.sourceforge.net/skim-app/?rev=6959&view=rev
Author:   hofman
Date:     2010-12-11 00:44:32 +0000 (Sat, 11 Dec 2010)

Log Message:
-----------
release keychain item ref that was added, Keychain Access does not follow 
naming standards

Modified Paths:
--------------
    trunk/SKMainDocument.m

Modified: trunk/SKMainDocument.m
===================================================================
--- trunk/SKMainDocument.m      2010-12-10 16:07:16 UTC (rev 6958)
+++ trunk/SKMainDocument.m      2010-12-11 00:44:32 UTC (rev 6959)
@@ -1812,6 +1812,8 @@
                     
                     err = SecKeychainItemModifyAttributesAndData(itemRef, 
&attributes, strlen(passwordData), passwordData);
                 }
+                // accroding to the docs we should release the itemRef, even 
though the function name does not contain Copy or Create
+                SKCFDESTROY(itemRef);
             } else 
                 NSLog(@"Error %d occurred setting password", err);
         }


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
Oracle to DB2 Conversion Guide: Learn learn about native support for PL/SQL,
new data types, scalar functions, improved concurrency, built-in packages, 
OCI, SQL*Plus, data movement tools, best practices and more.
http://p.sf.net/sfu/oracle-sfdev2dev 
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to