[Skim-app-commit] SF.net SVN: skim-app:[7226] trunk/NSDocument_SKExtensions.m

[hofman]

Revision: 7226
          http://skim-app.svn.sourceforge.net/skim-app/?rev=7226&view=rev
Author:   hofman
Date:     2011-05-12 09:58:41 +0000 (Thu, 12 May 2011)

Log Message:
-----------
fast enumeration of notes for fdf string, increase counter inside statement

Modified Paths:
--------------
    trunk/NSDocument_SKExtensions.m

Modified: trunk/NSDocument_SKExtensions.m
===================================================================
--- trunk/NSDocument_SKExtensions.m     2011-05-11 15:15:46 UTC (rev 7225)
+++ trunk/NSDocument_SKExtensions.m     2011-05-12 09:58:41 UTC (rev 7226)
@@ -212,14 +212,14 @@
 }
 
 - (NSData *)notesFDFDataForFile:(NSString *)filename fileIDStrings:(NSArray 
*)fileIDStrings {
-    NSInteger i, count = [[self notes] count];
+    NSInteger i = 0;
     NSMutableString *string = [NSMutableString 
stringWithFormat:@"%%FDF-1.2\n%%%C%C%C%C\n", 0xe2, 0xe3, 0xcf, 0xd3];
     NSMutableString *annots = [NSMutableString string];
-    for (i = 0; i < count; i++) {
-        [string appendFormat:@"%ld 0 obj<<%@>>\nendobj\n", (long)(i + 1), 
[[[self notes] objectAtIndex:i] fdfString]];
-        [annots appendFormat:@"%ld 0 R ", (long)(i + 1)];
+    for (PDFAnnotation *note in [self notes]) {
+        [string appendFormat:@"%ld 0 obj<<%@>>\nendobj\n", (long)(++i), [note 
fdfString]];
+        [annots appendFormat:@"%ld 0 R ", (long)i];
     }
-    [string appendFormat:@"%ld 0 obj<<", (long)(i + 1)];
+    [string appendFormat:@"%ld 0 obj<<", (long)(++i)];
     [string appendFDFName:SKFDFFDFKey];
     [string appendString:@"<<"];
     [string appendFDFName:SKFDFAnnotationsKey];
@@ -237,7 +237,7 @@
     [string appendString:@">>\nendobj\n"];
     [string appendString:@"trailer\n<<"];
     [string appendFDFName:SKFDFRootKey];
-    [string appendFormat:@" %ld 0 R", (long)(i + 1)];
+    [string appendFormat:@" %ld 0 R", (long)i];
     [string appendString:@">>\n"];
     [string appendString:@"%%EOF\n"];
     return [string dataUsingEncoding:NSISOLatin1StringEncoding];


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit