Revision: 10193
http://sourceforge.net/p/skim-app/code/10193
Author: hofman
Date: 2018-12-28 14:39:43 +0000 (Fri, 28 Dec 2018)
Log Message:
-----------
make line well and font well non opaque and don't draw control color first for
bezel
Modified Paths:
--------------
trunk/NSGraphics_SKExtensions.m
trunk/SKFontWell.m
trunk/SKLineWell.m
Modified: trunk/NSGraphics_SKExtensions.m
===================================================================
--- trunk/NSGraphics_SKExtensions.m 2018-12-28 14:19:03 UTC (rev 10192)
+++ trunk/NSGraphics_SKExtensions.m 2018-12-28 14:39:43 UTC (rev 10193)
@@ -128,8 +128,6 @@
cell = [[NSTextFieldCell alloc] initTextCell:@""];
[cell setBezeled:YES];
}
- [[NSColor controlColor] setFill];
- NSRectFill(rect);
[cell drawWithFrame:rect inView:controlView];
[cell setControlView:nil];
}
Modified: trunk/SKFontWell.m
===================================================================
--- trunk/SKFontWell.m 2018-12-28 14:19:03 UTC (rev 10192)
+++ trunk/SKFontWell.m 2018-12-28 14:39:43 UTC (rev 10193)
@@ -153,7 +153,7 @@
[super dealloc];
}
-- (BOOL)isOpaque{ return YES; }
+- (BOOL)isOpaque{ return NO; }
- (void)viewWillMoveToWindow:(NSWindow *)newWindow {
[self deactivate];
@@ -514,7 +514,7 @@
[NSGraphicsContext saveGraphicsState];
// @@ Dark mode
[[[NSColor controlTextColor] colorWithAlphaComponent:0.3] setFill];
- NSFrameRectWithWidthUsingOperation(frame, 1.0,
SKHasDarkAppearance(nil) ? NSCompositePlusLighter : NSCompositePlusDarker);
+ NSFrameRectWithWidthUsingOperation(frame, 1.0,
SKHasDarkAppearance(controlView) ? NSCompositePlusLighter :
NSCompositePlusDarker);
[NSGraphicsContext restoreGraphicsState];
}
Modified: trunk/SKLineWell.m
===================================================================
--- trunk/SKLineWell.m 2018-12-28 14:19:03 UTC (rev 10192)
+++ trunk/SKLineWell.m 2018-12-28 14:39:43 UTC (rev 10193)
@@ -161,7 +161,7 @@
[super dealloc];
}
-- (BOOL)isOpaque{ return YES; }
+- (BOOL)isOpaque{ return NO; }
- (BOOL)acceptsFirstResponder { return [self canActivate]; }
@@ -282,7 +282,7 @@
[NSGraphicsContext saveGraphicsState];
// @@ Dark mode
[[[NSColor controlTextColor] colorWithAlphaComponent:0.3] setFill];
- NSFrameRectWithWidthUsingOperation(bounds, 1.0,
SKHasDarkAppearance(nil) ? NSCompositePlusLighter : NSCompositePlusDarker);
+ NSFrameRectWithWidthUsingOperation(bounds, 1.0,
SKHasDarkAppearance(self) ? NSCompositePlusLighter : NSCompositePlusDarker);
[NSGraphicsContext restoreGraphicsState];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
