[Skim-app-commit] SF.net SVN: skim-app:[12403] trunk/SKAlias.m

[hofman--- via Skim-app-commit]

Revision: 12403
          http://sourceforge.net/p/skim-app/code/12403
Author:   hofman
Date:     2021-09-07 16:41:56 +0000 (Tue, 07 Sep 2021)
Log Message:
-----------
Assign bookmark data or alias handle directly. Destroy alias handle when init 
fails, should not happen.

Modified Paths:
--------------
    trunk/SKAlias.m

Modified: trunk/SKAlias.m
===================================================================
--- trunk/SKAlias.m     2021-09-07 16:33:34 UTC (rev 12402)
+++ trunk/SKAlias.m     2021-09-07 16:41:56 UTC (rev 12403)
@@ -93,20 +93,14 @@
         [self release];
         self = nil;
     } else {
-        NSData *bookmarkData = (NSData 
*)CFURLCreateBookmarkDataFromAliasRecord(NULL, (CFDataRef)aliasData);
-        if (bookmarkData) {
-            self = [self initWithBookmarkData:bookmarkData];
-            [bookmarkData release];
-        } else {
-            AliasHandle handle = createAliasHandleFromData(aliasData);
-            if (handle == NULL) {
-                [self release];
-                self = nil;
-            } else {
-                self = [super init];
-                if (self) {
-                    aliasHandle = handle;
-                    data = [aliasData retain];
+        self = [super init];
+        if (self) {
+            data = (NSData *)CFURLCreateBookmarkDataFromAliasRecord(NULL, 
(CFDataRef)aliasData);
+            if (data == nil) {
+                aliasHandle = createAliasHandleFromData(aliasData);
+                if (aliasHandle == NULL) {
+                    [self release];
+                    self = nil;
                 }
             }
         }

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit