[Skim-app-commit] SF.net SVN: skim-app:[12528] trunk/NSGraphics_SKExtensions.m

[hofman--- via Skim-app-commit]

Revision: 12528
          http://sourceforge.net/p/skim-app/code/12528
Author:   hofman
Date:     2021-11-06 10:42:17 +0000 (Sat, 06 Nov 2021)
Log Message:
-----------
Check whether filter is created before adding to array

Modified Paths:
--------------
    trunk/NSGraphics_SKExtensions.m

Modified: trunk/NSGraphics_SKExtensions.m
===================================================================
--- trunk/NSGraphics_SKExtensions.m     2021-11-06 10:30:04 UTC (rev 12527)
+++ trunk/NSGraphics_SKExtensions.m     2021-11-06 10:42:17 UTC (rev 12528)
@@ -186,13 +186,18 @@
 
 extern NSArray *SKColorEffectFilters(void) {
     NSMutableArray *filters = [NSMutableArray array];
+    CIFilter *filter;
     CGFloat sepia = [[NSUserDefaults standardUserDefaults] 
doubleForKey:SKSepiaToneKey];
-    if (sepia > 0.0)
-        [filters addObject:[CIFilter filterWithName:@"CISepiaTone" 
keysAndValues:@"inputIntensity", [NSNumber numberWithDouble:fmin(sepia, 1.0)], 
nil]];
+    if (sepia > 0.0) {
+        if ((filter = [CIFilter filterWithName:@"CISepiaTone" 
keysAndValues:@"inputIntensity", [NSNumber numberWithDouble:fmin(sepia, 1.0)], 
nil]))
+            [filters addObject:filter];
+    }
     if (SKHasDarkAppearance(NSApp) && [[NSUserDefaults standardUserDefaults] 
boolForKey:SKInvertColorsInDarkModeKey]) {
         // this is almost equivalent to CIColorInvert, but with white mapped 
to dark gray ~ controlBackgroundColor
-        [filters addObject:[CIFilter filterWithName:@"CIColorMatrix" 
keysAndValues:@"inputRVector", [CIVector vectorWithX:-0.987 Y:0.0 Z:0.0], 
@"inputGVector", [CIVector vectorWithX:0.0 Y:-0.987 Z:0.0], @"inputBVector", 
[CIVector vectorWithX:0.0 Y:0.0 Z:-0.987], @"inputBiasVector", [CIVector 
vectorWithX:1.0 Y:1.0 Z:1.0], nil]];
-        [filters addObject:[CIFilter filterWithName:@"CIHueAdjust" 
keysAndValues:kCIInputAngleKey, [NSNumber numberWithDouble:M_PI], nil]];
+        if ((filter = [CIFilter filterWithName:@"CIColorMatrix" 
keysAndValues:@"inputRVector", [CIVector vectorWithX:-0.987 Y:0.0 Z:0.0], 
@"inputGVector", [CIVector vectorWithX:0.0 Y:-0.987 Z:0.0], @"inputBVector", 
[CIVector vectorWithX:0.0 Y:0.0 Z:-0.987], @"inputBiasVector", [CIVector 
vectorWithX:1.0 Y:1.0 Z:1.0], nil]))
+            [filters addObject:filter];
+        if ((filter = [CIFilter filterWithName:@"CIHueAdjust" 
keysAndValues:kCIInputAngleKey, [NSNumber numberWithDouble:M_PI], nil]))
+            [filters addObject:filter];
     }
     return filters;
 }

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit