Revision: 12624 http://sourceforge.net/p/skim-app/code/12624 Author: hofman Date: 2021-12-13 23:38:14 +0000 (Mon, 13 Dec 2021) Log Message: ----------- Fix join command. Get to selection from unevaluted arguments, continuous selection includes last character.
Modified Paths: -------------- trunk/SKJoinCommand.m Modified: trunk/SKJoinCommand.m =================================================================== --- trunk/SKJoinCommand.m 2021-12-13 16:12:38 UTC (rev 12623) +++ trunk/SKJoinCommand.m 2021-12-13 23:38:14 UTC (rev 12624) @@ -45,7 +45,7 @@ - (id)performDefaultImplementation { id dP = [self directParameter]; - NSDictionary *args = [self evaluatedArguments]; + NSDictionary *args = [self arguments]; id other = [args objectForKey:@"To"]; BOOL continuous = [[args objectForKey:@"Continuous"] boolValue]; PDFSelection *selection = [PDFSelection selectionWithSpecifier:dP]; @@ -63,7 +63,7 @@ NSUInteger firstIndex = [selection safeIndexOfFirstCharacterOnPage:firstPage]; NSUInteger lastIndex = [selection safeIndexOfLastCharacterOnPage:lastPage]; if (firstIndex != NSNotFound && lastIndex != NSNotFound) - selection = [[firstPage document] selectionFromPage:firstPage atCharacterIndex:firstIndex toPage:lastPage atCharacterIndex:lastIndex - 1]; + selection = [[firstPage document] selectionFromPage:firstPage atCharacterIndex:firstIndex toPage:lastPage atCharacterIndex:lastIndex]; } } return selection ? [selection objectSpecifier] : [NSArray array]; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. _______________________________________________ Skim-app-commit mailing list Skim-app-commit@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/skim-app-commit