[Skim-app-commit] SF.net SVN: skim-app:[12706] trunk

[hofman--- via Skim-app-commit]

Revision: 12706
          http://sourceforge.net/p/skim-app/code/12706
Author:   hofman
Date:     2022-01-12 10:35:08 +0000 (Wed, 12 Jan 2022)
Log Message:
-----------
No need for custom initializer

Modified Paths:
--------------
    trunk/SKPDFView.m
    trunk/SKTransitionController.h
    trunk/SKTransitionController.m

Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m   2022-01-11 17:57:44 UTC (rev 12705)
+++ trunk/SKPDFView.m   2022-01-12 10:35:08 UTC (rev 12706)
@@ -949,8 +949,10 @@
 }
 
 - (SKTransitionController * )transitionController {
-    if (transitionController == nil)
-        transitionController = [[SKTransitionController alloc] 
initForView:self];
+    if (transitionController == nil) {
+        transitionController = [[SKTransitionController alloc] init];
+        [transitionController setView:self];
+    }
     return transitionController;
 }
 

Modified: trunk/SKTransitionController.h
===================================================================
--- trunk/SKTransitionController.h      2022-01-11 17:57:44 UTC (rev 12705)
+++ trunk/SKTransitionController.h      2022-01-12 10:35:08 UTC (rev 12706)
@@ -66,8 +66,6 @@
 + (BOOL)isCoreGraphicsTransition:(SKTransitionStyle)style;
 + (BOOL)isCoreImageTransition:(SKTransitionStyle)style;
 
-- (id)initForView:(NSView *)aView;
-
 - (void)animateForRect:(NSRect)rect from:(NSUInteger)fromIndex 
to:(NSUInteger)toIndex change:(NSRect (^)(void))change;
 
 @end

Modified: trunk/SKTransitionController.m
===================================================================
--- trunk/SKTransitionController.m      2022-01-11 17:57:44 UTC (rev 12705)
+++ trunk/SKTransitionController.m      2022-01-12 10:35:08 UTC (rev 12706)
@@ -297,11 +297,9 @@
     return style >= SKCoreImageTransition;
 }
 
-- (id)initForView:(NSView *)aView {
+- (id)init {
     self = [super init];
     if (self) {
-        view = aView; // don't retain as it may retain us
-        
         transition = [[SKTransitionInfo alloc] init];
     }
     return self;

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit