[Skim-app-commit] SF.net SVN: skim-app:[13012] trunk

[hofman--- via Skim-app-commit]

Revision: 13012
          http://sourceforge.net/p/skim-app/code/13012
Author:   hofman
Date:     2022-07-11 16:42:56 +0000 (Mon, 11 Jul 2022)
Log Message:
-----------
implement topbar accessibility by making it a subclass of group view

Modified Paths:
--------------
    trunk/SKFindController.m
    trunk/SKSideViewController.m
    trunk/SKTopBarView.h
    trunk/SKTopBarView.m

Modified: trunk/SKFindController.m
===================================================================
--- trunk/SKFindController.m    2022-07-11 16:34:23 UTC (rev 13011)
+++ trunk/SKFindController.m    2022-07-11 16:42:56 UTC (rev 13012)
@@ -68,6 +68,8 @@
 - (void)viewDidLoad {
     [super viewDidLoad];
     
+    [[self view] setAccessibilityLabel:NSLocalizedString(@"search bar", 
@"Accessibility description")];
+    
     NSMenu *menu = [NSMenu menu];
     [menu addItemWithTitle:NSLocalizedString(@"Ignore Case", @"Menu item 
title") action:@selector(toggleCaseInsensitiveFind:) target:self];
     [[findField cell] setSearchMenuTemplate:menu];

Modified: trunk/SKSideViewController.m
===================================================================
--- trunk/SKSideViewController.m        2022-07-11 16:34:23 UTC (rev 13011)
+++ trunk/SKSideViewController.m        2022-07-11 16:42:56 UTC (rev 13012)
@@ -62,6 +62,11 @@
     [super dealloc];
 }
 
+- (void)viewDidLoad {
+    [super viewDidLoad];
+    [topBar setAccessibilityLabel:NSLocalizedString(@"search bar", 
@"Accessibility description")];
+}
+
 #pragma mark Accessors
 
 - (NSArray *)tableViews { return nil; }

Modified: trunk/SKTopBarView.h
===================================================================
--- trunk/SKTopBarView.h        2022-07-11 16:34:23 UTC (rev 13011)
+++ trunk/SKTopBarView.h        2022-07-11 16:42:56 UTC (rev 13012)
@@ -37,6 +37,7 @@
  */
 
 #import <Cocoa/Cocoa.h>
+#import "SKGroupView.h"
 
 typedef NS_ENUM(NSInteger, SKTopBarStyle) {
     SKTopBarStyleDefault,
@@ -46,7 +47,7 @@
 
 @class SKBackgroundView;
 
-@interface SKTopBarView : NSView {
+@interface SKTopBarView : SKGroupView {
     NSView *contentView;
     NSVisualEffectView *blurView;
     SKBackgroundView *backgroundView;

Modified: trunk/SKTopBarView.m
===================================================================
--- trunk/SKTopBarView.m        2022-07-11 16:34:23 UTC (rev 13011)
+++ trunk/SKTopBarView.m        2022-07-11 16:42:56 UTC (rev 13012)
@@ -157,30 +157,6 @@
     [backgroundView setNeedsDisplay:YES];
 }
 
-- (BOOL)isAccessibilityElement {
-    return YES;
-}
-
-- (NSString *)accessibilityRole {
-    return NSAccessibilityGroupRole;
-}
-
-- (NSString *)accessibilityRoleDescription {
-    return NSAccessibilityRoleDescription(NSAccessibilityGroupRole, nil);
-}
-
-- (NSRect)accessibilityFrame {
-    return [self convertRectToScreen:[self bounds]];
-}
-
-- (id)accessibilityParent {
-    return NSAccessibilityUnignoredAncestor([self superview]);
-}
-
-- (NSString *)accessibilityLabel {
-    return NSLocalizedString(@"search bar", @"Accessibility description");
-}
-
 @end
 
 #pragma mark -

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit