Revision: 13457
          http://sourceforge.net/p/skim-app/code/13457
Author:   hofman
Date:     2023-06-08 21:18:53 +0000 (Thu, 08 Jun 2023)
Log Message:
-----------
revert previous commits, don't cancel page rewind, PDFView may call some 
methods when it really shouldn't

Modified Paths:
--------------
    trunk/SKPDFView.m

Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m   2023-06-08 14:49:05 UTC (rev 13456)
+++ trunk/SKPDFView.m   2023-06-08 21:18:53 UTC (rev 13457)
@@ -1255,7 +1255,6 @@
         [self setToolMode:([self toolMode] + 1) % TOOL_MODE_COUNT];
         return;
     }
-    [self setNeedsRewind:NO];;
     if (interactionMode == SKPresentationMode && [self window] && 
[transitionController hasTransition] && [self canGoToNextPage])
         [self animateTransitionForNextPage:YES];
     else
@@ -1268,7 +1267,6 @@
         [self setToolMode:([self toolMode] + TOOL_MODE_COUNT - 1) % 
TOOL_MODE_COUNT];
         return;
     }
-    [self setNeedsRewind:NO];;
     if (interactionMode == SKPresentationMode && [self window] && 
[transitionController hasTransition] && [self canGoToPreviousPage])
         [self animateTransitionForNextPage:NO];
     else
@@ -1281,7 +1279,6 @@
         [self setAnnotationMode:([self annotationMode] + ANNOTATION_MODE_COUNT 
- 1) % ANNOTATION_MODE_COUNT];
         return;
     } else {
-        [self setNeedsRewind:NO];;
         [super goToFirstPage:sender];
     }
 }
@@ -1291,21 +1288,10 @@
         [self setAnnotationMode:([self annotationMode] + 1) % 
ANNOTATION_MODE_COUNT];
         return;
     } else {
-        [self setNeedsRewind:NO];;
         [super goToLastPage:sender];
     }
 }
 
-- (void)goToPage:(PDFPage *)page {
-    [self setNeedsRewind:NO];
-    [super goToPage:page];
-}
-
-- (void)goToCurrentPage:(PDFPage *)page {
-    [self setNeedsRewind:NO];
-    [super goToCurrentPage:page];
-}
-
 - (IBAction)delete:(id)sender
 {
        if ([currentAnnotation isSkimNote])
@@ -1761,7 +1747,6 @@
         [self goToPage:page];
         return;
     }
-    [self setNeedsRewind:NO];
     PDFDisplayMode mode = [self extendedDisplayMode];
     if (mode != kPDFDisplaySinglePage) {
         NSScrollView *scrollView = [self scrollView];
@@ -3149,8 +3134,6 @@
         
         if (wasPageDisplayed == NO)
             [self goToPage:page];
-        else
-            [self setNeedsRewind:NO];
         
         if (interactionMode != SKPresentationMode) {
             if (showBar) {

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to