Revision: 13517
          http://sourceforge.net/p/skim-app/code/13517
Author:   hofman
Date:     2023-06-28 16:06:58 +0000 (Wed, 28 Jun 2023)
Log Message:
-----------
check change of obsevred value before checking change to duration

Modified Paths:
--------------
    trunk/SKPresentationOptionsSheetController.m

Modified: trunk/SKPresentationOptionsSheetController.m
===================================================================
--- trunk/SKPresentationOptionsSheetController.m        2023-06-28 15:58:57 UTC 
(rev 13516)
+++ trunk/SKPresentationOptionsSheetController.m        2023-06-28 16:06:58 UTC 
(rev 13517)
@@ -409,6 +409,9 @@
         if ([newValue isEqual:[NSNull null]]) newValue = nil;
         if ([oldValue isEqual:[NSNull null]]) oldValue = nil;
         
+        if (newValue == oldValue || [newValue isEqual:oldValue])
+            return;
+            
         if ([keyPath isEqualToString:DURATION_KEY]) {
             if ([changedTransitions containsObject:object])
                 return;
@@ -417,8 +420,7 @@
             [changedTransitions addObject:object];
         }
         
-        if ((newValue || oldValue) && [newValue isEqual:oldValue] == NO)
-            [[[self undoManager] prepareWithInvocationTarget:self] 
setValue:oldValue forKey:keyPath ofTransition:object];
+        [[[self undoManager] prepareWithInvocationTarget:self] 
setValue:oldValue forKey:keyPath ofTransition:object];
     } else {
         [super observeValueForKeyPath:keyPath ofObject:object change:change 
context:context];
     }

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to