Revision: 13626
http://sourceforge.net/p/skim-app/code/13626
Author: hofman
Date: 2023-09-03 08:29:24 +0000 (Sun, 03 Sep 2023)
Log Message:
-----------
don't clear placeholder pdf document when setting pdf document, as we may now
have set notes in it
Modified Paths:
--------------
trunk/SKMainWindowController.m
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2023-09-01 14:57:38 UTC (rev 13625)
+++ trunk/SKMainWindowController.m 2023-09-03 08:29:24 UTC (rev 13626)
@@ -1032,10 +1032,10 @@
NSMutableIndexSet *pageIndexes = [NSMutableIndexSet indexSet];
BOOL isConvert = [notesToRemove count] > 0 && [[notesToRemove firstObject]
isSkimNote] == NO;
+ SKDESTROY(placeholderPdfDocument);
if ([pdfDoc allowsNotes] == NO && [noteDicts count] > 0) {
// there should not be any notesToRemove at this point
NSUInteger i, pageCount = MIN([pdfDoc pageCount], [[noteDicts
valueForKeyPath:@"@max.pageIndex"] unsignedIntegerValue] + 1);
- SKDESTROY(placeholderPdfDocument);
pdfDoc = placeholderPdfDocument = [[SKPDFDocument alloc] init];
[placeholderPdfDocument setContainingDocument:[self document]];
for (i = 0; i < pageCount; i++) {
@@ -1167,7 +1167,6 @@
[self removeAllObjectsFromNotes];
[self setThumbnails:nil];
[self clearWidgets];
- SKDESTROY(placeholderPdfDocument);
SKDESTROY(placeholderWidgetProperties);
// remmeber snapshots and close them, without animation
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit