Revision: 13726
http://sourceforge.net/p/skim-app/code/13726
Author: hofman
Date: 2023-11-04 10:17:01 +0000 (Sat, 04 Nov 2023)
Log Message:
-----------
Set deployment target to 10.13. Ignore warnings about NSConnection deprecation.
Modified Paths:
--------------
trunk/SkimNotes/Configurations/SkimNotes-Common.xcconfig
trunk/SkimNotes/SKNAgentListener.h
trunk/SkimNotes/SKNAgentListener.m
trunk/SkimNotes/SKNSkimReader.m
Modified: trunk/SkimNotes/Configurations/SkimNotes-Common.xcconfig
===================================================================
--- trunk/SkimNotes/Configurations/SkimNotes-Common.xcconfig 2023-11-04
10:11:10 UTC (rev 13725)
+++ trunk/SkimNotes/Configurations/SkimNotes-Common.xcconfig 2023-11-04
10:17:01 UTC (rev 13726)
@@ -4,7 +4,7 @@
DEBUG_INFORMATION_FORMAT = dwarf
ARCHS = $(ARCHS_STANDARD)
-MACOSX_DEPLOYMENT_TARGET = 10.9
+MACOSX_DEPLOYMENT_TARGET = 10.13
COPY_PHASE_STRIP = NO
SKIP_INSTALL = YES
Modified: trunk/SkimNotes/SKNAgentListener.h
===================================================================
--- trunk/SkimNotes/SKNAgentListener.h 2023-11-04 10:11:10 UTC (rev 13725)
+++ trunk/SkimNotes/SKNAgentListener.h 2023-11-04 10:17:01 UTC (rev 13726)
@@ -41,10 +41,10 @@
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
@interface SKNAgentListener : NSObject <NSConnectionDelegate>
-#pragma clang diagnostic pop
{
NSConnection *connection;
}
+#pragma clang diagnostic pop
- (id)initWithServerName:(NSString *)serverName;
- (void)destroyConnection;
Modified: trunk/SkimNotes/SKNAgentListener.m
===================================================================
--- trunk/SkimNotes/SKNAgentListener.m 2023-11-04 10:11:10 UTC (rev 13725)
+++ trunk/SkimNotes/SKNAgentListener.m 2023-11-04 10:17:01 UTC (rev 13726)
@@ -45,7 +45,10 @@
{
self = [super init];
if (self) {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
connection = [[NSConnection alloc] initWithReceivePort:[NSPort port]
sendPort:nil];
+#pragma clang diagnostic pop
NSProtocolChecker *checker = [NSProtocolChecker
protocolCheckerWithTarget:self protocol:@protocol(SKNAgentListenerProtocol)];
[connection setRootObject:checker];
[connection setDelegate:self];
@@ -92,7 +95,10 @@
}
// first app to connect will be the owner of this instance of the program;
when the connection dies, so do we
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
- (BOOL)makeNewConnection:(NSConnection *)newConnection sender:(NSConnection
*)parentConnection
+#pragma clang diagnostic pop
{
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(portDied:) name:NSPortDidBecomeInvalidNotification
object:[newConnection sendPort]];
fprintf(stderr, "skimnotes agent pid %d connection registered\n",
getpid());
Modified: trunk/SkimNotes/SKNSkimReader.m
===================================================================
--- trunk/SkimNotes/SKNSkimReader.m 2023-11-04 10:11:10 UTC (rev 13725)
+++ trunk/SkimNotes/SKNSkimReader.m 2023-11-04 10:17:01 UTC (rev 13726)
@@ -51,7 +51,10 @@
}
- (void)destroyConnection {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
[[NSNotificationCenter defaultCenter] removeObserver:self
name:NSConnectionDidDieNotification object:connection];
+#pragma clang diagnostic pop
[agent release];
agent = nil;
@@ -98,7 +101,10 @@
}
- (void)handleConnectionDied:(NSNotification *)note {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
[[NSNotificationCenter defaultCenter] removeObserver:self
name:NSConnectionDidDieNotification object:[note object]];
+#pragma clang diagnostic pop
// ensure the proxy ivar and ports are cleaned up; is it still okay to
message it?
[self destroyConnection];
}
@@ -150,18 +156,27 @@
// no point in trying to connect if the task didn't launch
if ([self launchedTask]) {
int maxTries = 5;
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
connection = [[NSConnection connectionWithRegisteredName:[self
agentIdentifier] host:nil] retain];
+#pragma clang diagnostic pop
// if we try to read data before the server is fully set up,
connection will still be nil
while (nil == connection && maxTries--) {
[NSThread sleepUntilDate:[NSDate
dateWithTimeIntervalSinceNow:0.1]];
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
connection = [[NSConnection connectionWithRegisteredName:[self
agentIdentifier] host:nil] retain];
+#pragma clang diagnostic pop
}
if (connection) {
// keep an eye on the connection from our end, so we can retain
the proxy object
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(handleConnectionDied:) name:NSConnectionDidDieNotification
object:connection];
+#pragma clang diagnostic pop
// if we don't set these explicitly, timeout never seems to take
place
[connection setRequestTimeout:AGENT_TIMEOUT];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
