Revision: 13882
          http://sourceforge.net/p/skim-app/code/13882
Author:   hofman
Date:     2023-12-11 10:47:28 +0000 (Mon, 11 Dec 2023)
Log Message:
-----------
Don't retain and autorelease presentationPreview controller, it is retained as 
a windowController by the document

Modified Paths:
--------------
    trunk/SKMainWindowController.m
    trunk/SKMainWindowController_FullScreen.m

Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m      2023-12-11 10:43:10 UTC (rev 13881)
+++ trunk/SKMainWindowController.m      2023-12-11 10:47:28 UTC (rev 13882)
@@ -2469,7 +2469,6 @@
 
 - (void)snapshotControllerWillClose:(SKSnapshotWindowController *)controller {
     if (controller == presentationPreview) {
-        [presentationPreview autorelease];
         presentationPreview = nil;
     } else {
         [rightSideController.snapshotTableView beginUpdates];

Modified: trunk/SKMainWindowController_FullScreen.m
===================================================================
--- trunk/SKMainWindowController_FullScreen.m   2023-12-11 10:43:10 UTC (rev 
13881)
+++ trunk/SKMainWindowController_FullScreen.m   2023-12-11 10:47:28 UTC (rev 
13882)
@@ -248,6 +248,7 @@
                                 displayOnScreen:screen];
             
             [[self document] addWindowController:presentationPreview];
+            [presentationPreview release];
         } else {
             [[self presentationNotesDocument] setCurrentPage:[pdfDoc 
pageAtIndex:pageIndex]];
         }
@@ -541,7 +542,6 @@
             if (presentationPreview) {
                 [[presentationPreview window] 
setAnimationBehavior:NSWindowAnimationBehaviorNone];
                 [presentationPreview close];
-                [presentationPreview autorelease];
             }
         }];
     

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to