Revision: 13890
          http://sourceforge.net/p/skim-app/code/13890
Author:   hofman
Date:     2023-12-11 17:47:57 +0000 (Mon, 11 Dec 2023)
Log Message:
-----------
use CFType variable for return value

Modified Paths:
--------------
    trunk/SKKeychain.m

Modified: trunk/SKKeychain.m
===================================================================
--- trunk/SKKeychain.m  2023-12-11 17:30:55 UTC (rev 13889)
+++ trunk/SKKeychain.m  2023-12-11 17:47:57 UTC (rev 13890)
@@ -44,7 +44,7 @@
 
 + (NSString *)passwordForService:(NSString *)service account:(NSString 
*)account status:(SKPasswordStatus *)status {
     NSMutableDictionary *query = [NSMutableDictionary dictionary];
-    NSData *passwordData = nil;
+    CFTypeRef passwordData = nil;
     NSString *password = nil;
     
     [query setObject:(NSString *)kSecClassGenericPassword forKey:(NSString 
*)kSecClass];
@@ -55,12 +55,12 @@
         [query setObject:account forKey:(NSString *)kSecAttrAccount];
     [query setObject:@YES forKey:(NSString *)kSecReturnData];
     
-    OSStatus err = SecItemCopyMatching((CFDictionaryRef)query, (CFTypeRef 
*)&passwordData);
+    OSStatus err = SecItemCopyMatching((CFDictionaryRef)query, &passwordData);
     
     if (err == noErr) {
         if (passwordData) {
-            password = [[[NSString alloc] initWithData:passwordData 
encoding:NSUTF8StringEncoding] autorelease];
-            [passwordData release];
+            password = [[[NSString alloc] initWithData:(NSData *)passwordData 
encoding:NSUTF8StringEncoding] autorelease];
+            CFRelease(passwordData);
         }
         if (status) *status = SKPasswordStatusFound;
     } else if (err == errSecItemNotFound) {

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to