Revision: 13968
http://sourceforge.net/p/skim-app/code/13968
Author: hofman
Date: 2023-12-23 18:04:37 +0000 (Sat, 23 Dec 2023)
Log Message:
-----------
better type
Modified Paths:
--------------
trunk/NSString_SKExtensions.h
trunk/NSString_SKExtensions.m
trunk/PDFPage_SKExtensions.h
trunk/PDFPage_SKExtensions.m
trunk/SKBookmarkController.h
trunk/SKDownload.h
trunk/SKMainDocument.h
trunk/SKOutlineView.h
Modified: trunk/NSString_SKExtensions.h
===================================================================
--- trunk/NSString_SKExtensions.h 2023-12-23 17:53:57 UTC (rev 13967)
+++ trunk/NSString_SKExtensions.h 2023-12-23 18:04:37 UTC (rev 13968)
@@ -42,7 +42,7 @@
@interface NSString (SKExtensions)
-- (NSComparisonResult)noteTypeCompare:(id)other;
+- (NSComparisonResult)noteTypeCompare:(NSString *)other;
@property (nonatomic, readonly) NSString
*stringByCollapsingWhitespaceAndNewlinesAndRemovingSurroundingWhitespaceAndNewlines;
@property (nonatomic, readonly) NSString *stringByRemovingAliens;
Modified: trunk/NSString_SKExtensions.m
===================================================================
--- trunk/NSString_SKExtensions.m 2023-12-23 17:53:57 UTC (rev 13967)
+++ trunk/NSString_SKExtensions.m 2023-12-23 18:04:37 UTC (rev 13968)
@@ -81,7 +81,7 @@
return [NSNumber numberWithInteger:order];
}
-- (NSComparisonResult)noteTypeCompare:(id)other {
+- (NSComparisonResult)noteTypeCompare:(NSString *)other {
return [[self noteTypeOrder] compare:[other noteTypeOrder]];
}
Modified: trunk/PDFPage_SKExtensions.h
===================================================================
--- trunk/PDFPage_SKExtensions.h 2023-12-23 17:53:57 UTC (rev 13967)
+++ trunk/PDFPage_SKExtensions.h 2023-12-23 18:04:37 UTC (rev 13968)
@@ -109,8 +109,8 @@
- (SKLine *)objectInLinesAtIndex:(NSUInteger)anIndex;
@property (nonatomic, nullable, readonly) NSTextStorage *richText;
@property (nonatomic, nullable, readonly) NSArray<PDFAnnotation *> *notes;
-- (nullable id)valueInNotesWithUniqueID:(NSString *)aUniqueID;
-- (void)insertObject:(id)newNote inNotesAtIndex:(NSUInteger)index;
+- (nullable PDFAnnotation *)valueInNotesWithUniqueID:(NSString *)aUniqueID;
+- (void)insertObject:(PDFAnnotation *)newNote inNotesAtIndex:(NSUInteger)index;
- (void)removeObjectFromNotesAtIndex:(NSUInteger)index;
- (nullable id)handleGrabScriptCommand:(NSScriptCommand *)command;
Modified: trunk/PDFPage_SKExtensions.m
===================================================================
--- trunk/PDFPage_SKExtensions.m 2023-12-23 17:53:57 UTC (rev 13967)
+++ trunk/PDFPage_SKExtensions.m 2023-12-23 18:04:37 UTC (rev 13968)
@@ -665,7 +665,7 @@
return notes;
}
-- (id)valueInNotesWithUniqueID:(NSString *)aUniqueID {
+- (PDFAnnotation *)valueInNotesWithUniqueID:(NSString *)aUniqueID {
for (PDFAnnotation *annotation in [self notes]) {
if ([[annotation uniqueID] isEqualToString:aUniqueID])
return annotation;
@@ -673,7 +673,7 @@
return nil;
}
-- (void)insertObject:(id)newNote inNotesAtIndex:(NSUInteger)anIndex {
+- (void)insertObject:(PDFAnnotation *)newNote
inNotesAtIndex:(NSUInteger)anIndex {
if ([self isEditable] && [[self document] allowsNotes]) {
[[self document] addAnnotation:newNote toPage:self];
[[[self containingDocument] undoManager]
setActionName:NSLocalizedString(@"Add Note", @"Undo action name")];
Modified: trunk/SKBookmarkController.h
===================================================================
--- trunk/SKBookmarkController.h 2023-12-23 17:53:57 UTC (rev 13967)
+++ trunk/SKBookmarkController.h 2023-12-23 18:04:37 UTC (rev 13968)
@@ -74,7 +74,7 @@
@property (nonatomic, readonly) SKBookmark *bookmarkRoot;
@property (nonatomic, nullable, readonly) SKBookmark *previousSession;
-- (IBAction)openBookmark:(id)sender;
+- (IBAction)openBookmark:(nullable id)sender;
- (IBAction)doubleClickBookmark:(nullable id)sender;
- (IBAction)insertBookmarkFolder:(nullable id)sender;
Modified: trunk/SKDownload.h
===================================================================
--- trunk/SKDownload.h 2023-12-23 17:53:57 UTC (rev 13967)
+++ trunk/SKDownload.h 2023-12-23 18:04:37 UTC (rev 13968)
@@ -108,8 +108,8 @@
- (void)cleanup;
- (void)moveToTrash;
-- (void)resume:(id)sender;
-- (void)cancelOrRemove:(id)sender;
+- (void)resume:(nullable id)sender;
+- (void)cancelOrRemove:(nullable id)sender;
- (void)downloadDidWriteData:(int64_t)bytesWritten
totalBytesWritten:(int64_t)totalBytesWritten
totalBytesExpectedToWrite:(int64_t)totalBytesExpectedToWrite;
- (void)downloadDidFinishDownloadingToURL:(NSURL *)location;
Modified: trunk/SKMainDocument.h
===================================================================
--- trunk/SKMainDocument.h 2023-12-23 17:53:57 UTC (rev 13967)
+++ trunk/SKMainDocument.h 2023-12-23 18:04:37 UTC (rev 13968)
@@ -73,9 +73,9 @@
} mdFlags;
}
-- (IBAction)readNotes:(id)sender;
-- (IBAction)convertNotes:(id)sender;
-- (IBAction)moveToTrash:(id)sender;
+- (IBAction)readNotes:(nullable id)sender;
+- (IBAction)convertNotes:(nullable id)sender;
+- (IBAction)moveToTrash:(nullable id)sender;
@property (nonatomic, nullable, readonly) SKMainWindowController
*mainWindowController;
@property (nonatomic, nullable, readonly) PDFDocument *pdfDocument;
Modified: trunk/SKOutlineView.h
===================================================================
--- trunk/SKOutlineView.h 2023-12-23 17:53:57 UTC (rev 13967)
+++ trunk/SKOutlineView.h 2023-12-23 18:04:37 UTC (rev 13968)
@@ -76,9 +76,9 @@
- (NSArray *)itemsAtRowIndexes:(NSIndexSet *)indexes;
-- (void)delete:(id)sender;
-- (void)copy:(id)sender;
-- (void)paste:(id)sender;
+- (void)delete:(nullable id)sender;
+- (void)copy:(nullable id)sender;
+- (void)paste:(nullable id)sender;
- (void)scrollToBeginningOfDocument:(nullable id)sender;
- (void)scrollToEndOfDocument:(nullable id)sender;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
