Revision: 14040
          http://sourceforge.net/p/skim-app/code/14040
Author:   hofman
Date:     2024-02-03 23:33:46 +0000 (Sat, 03 Feb 2024)
Log Message:
-----------
correct goToDestination instead of doing all the scrolling ourselves

Modified Paths:
--------------
    trunk/PDFView_SKExtensions.m

Modified: trunk/PDFView_SKExtensions.m
===================================================================
--- trunk/PDFView_SKExtensions.m        2024-02-03 23:23:32 UTC (rev 14039)
+++ trunk/PDFView_SKExtensions.m        2024-02-03 23:33:46 UTC (rev 14040)
@@ -244,17 +244,17 @@
     PDFPage *page = [[self document] pageAtIndex:pageIndex];
     if (NSEqualPoints(point, SKUnspecifiedPoint)) {
         [self goToCurrentPage:page];
-    } else if (@available(macOS 12.0, *)) {
-        NSScrollView *scrollView = [self scrollView];
-        NSClipView *clipView = [scrollView contentView];
-        [self goToPage:page];
-        point = [self convertPoint:[self convertPoint:point fromPage:page] 
toView:clipView];
-        if ([clipView isFlipped] == NO)
-            point.y -= NSHeight([clipView visibleRect]) - [self 
convertSize:NSMakeSize(0.0, [scrollView contentInsets].top) 
toView:clipView].height;
-        [clipView scrollToPoint:point];
     } else {
         PDFDestination *destination = [[PDFDestination alloc] 
initWithPage:page atPoint:point];
         [self goToDestination:destination];
+        if (@available(macOS 12.0, *)) {
+            NSScrollView *scrollView = [self scrollView];
+            NSClipView *clipView = [scrollView contentView];
+            point = [self convertPoint:[self convertPoint:point fromPage:page] 
toView:clipView];
+            if ([clipView isFlipped] == NO)
+                point.y -= NSHeight([clipView visibleRect]) - [self 
convertSize:NSMakeSize(0.0, [scrollView contentInsets].top) 
toView:clipView].height;
+            [clipView scrollToPoint:point];
+        }
     }
 }
 

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to