Revision: 14048
          http://sourceforge.net/p/skim-app/code/14048
Author:   hofman
Date:     2024-02-15 15:30:24 +0000 (Thu, 15 Feb 2024)
Log Message:
-----------
destroy snapshot timer in cleanup

Modified Paths:
--------------
    trunk/SKMainWindowController.m
    trunk/SKMainWindowController_UI.m

Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m      2024-02-14 16:03:19 UTC (rev 14047)
+++ trunk/SKMainWindowController.m      2024-02-15 15:30:24 UTC (rev 14048)
@@ -272,6 +272,10 @@
 // this is called from windowWillClose:
 - (void)cleanup {
     mwcFlags.needsCleanup = 0;
+    if (snapshotTimer) {
+        [snapshotTimer invalidate];
+        snapshotTimer = nil;
+    }
     if (activity) {
         [[NSProcessInfo processInfo] endActivity:activity];
         activity = nil;

Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m   2024-02-14 16:03:19 UTC (rev 14047)
+++ trunk/SKMainWindowController_UI.m   2024-02-15 15:30:24 UTC (rev 14048)
@@ -254,11 +254,6 @@
             [self setRecentInfoNeedsUpdate:YES];
             [[self document] saveRecentDocumentInfo];
         }
-        // timers retain their target, so invalidate them now or they may keep 
firing after the PDF is gone
-        if (snapshotTimer) {
-            [snapshotTimer invalidate];
-            snapshotTimer = nil;
-        }
         if ([[pdfView document] isFinding])
             [[pdfView document] cancelFindString];
         if ((mwcFlags.isEditingTable || [pdfView isEditing]) && [self 
commitEditing] == NO)

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to