Revision: 14107
          http://sourceforge.net/p/skim-app/code/14107
Author:   hofman
Date:     2024-03-14 22:34:43 +0000 (Thu, 14 Mar 2024)
Log Message:
-----------
don't use mixed state for left side pane menu items

Modified Paths:
--------------
    trunk/SKMainWindowController_UI.m

Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m   2024-03-14 22:24:59 UTC (rev 14106)
+++ trunk/SKMainWindowController_UI.m   2024-03-14 22:34:43 UTC (rev 14107)
@@ -1827,7 +1827,7 @@
             [menuItem setTitle:NSLocalizedString(@"Show Notes Pane", @"Menu 
item title")];
         return [self interactionMode] != SKPresentationMode;
     } else if (action == @selector(changeLeftSidePaneState:)) {
-        [menuItem setState:mwcFlags.leftSidePaneState == 
(SKLeftSidePaneState)[menuItem tag] ? (([leftSideController.findTableView 
window] || [leftSideController.groupedFindTableView window]) ? 
NSControlStateValueMixed : NSControlStateValueOn) : NSControlStateValueOff];
+        [menuItem setState:mwcFlags.leftSidePaneState == 
(SKLeftSidePaneState)[menuItem tag] && ([leftSideController.findTableView 
window]== nil && [leftSideController.groupedFindTableView window] == nil) ? 
NSControlStateValueOn : NSControlStateValueOff];
         return (SKLeftSidePaneState)[menuItem tag] == SKSidePaneStateThumbnail 
|| [[pdfView document] outlineRoot];
     } else if (action == @selector(changeRightSidePaneState:)) {
         [menuItem setState:mwcFlags.rightSidePaneState == 
(SKRightSidePaneState)[menuItem tag] ? NSControlStateValueOn : 
NSControlStateValueOff];
@@ -1837,7 +1837,7 @@
             [menuItem setState:NSControlStateValueOff];
             return NO;
         }
-        [menuItem setState:mwcFlags.findPaneState == 
(SKFindPaneState)[menuItem tag] ? (([leftSideController.findTableView window] 
== nil && [leftSideController.groupedFindTableView window] == nil) ? 
NSControlStateValueMixed : NSControlStateValueOn) : NSControlStateValueOff];
+        [menuItem setState:((SKFindPaneState)mwcFlags.findPaneState == 
(SKFindPaneState)[menuItem tag] && ([leftSideController.findTableView window] 
|| [leftSideController.groupedFindTableView window])) ? NSControlStateValueOn : 
NSControlStateValueOff];
         return YES;
     } else if (action == @selector(toggleOverview:)) {
         if ([self hasOverview])

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to