Revision: 14119
          http://sourceforge.net/p/skim-app/code/14119
Author:   hofman
Date:     2024-03-20 16:56:48 +0000 (Wed, 20 Mar 2024)
Log Message:
-----------
Remove menu item to use current view settings as default, item title is 
impossibly lengthy, and its use is non-standard and can be confusing

Modified Paths:
--------------
    trunk/Base.lproj/MainMenu.xib
    trunk/SKMainWindowController_Actions.h
    trunk/SKMainWindowController_Actions.m
    trunk/SKMainWindowController_UI.m
    trunk/de.lproj/Localizable.strings
    trunk/de.lproj/MainMenu.strings
    trunk/en.lproj/Localizable.strings
    trunk/en.lproj/MainMenu.strings
    trunk/es.lproj/Localizable.strings
    trunk/es.lproj/MainMenu.strings
    trunk/fr.lproj/Localizable.strings
    trunk/fr.lproj/MainMenu.strings
    trunk/it.lproj/Localizable.strings
    trunk/it.lproj/MainMenu.strings
    trunk/ja.lproj/Localizable.strings
    trunk/ja.lproj/MainMenu.strings
    trunk/nl.lproj/Localizable.strings
    trunk/nl.lproj/MainMenu.strings
    trunk/pl.lproj/Localizable.strings
    trunk/pl.lproj/MainMenu.strings
    trunk/ru.lproj/Localizable.strings
    trunk/ru.lproj/MainMenu.strings
    trunk/zh_CN.lproj/Localizable.strings
    trunk/zh_CN.lproj/MainMenu.strings
    trunk/zh_TW.lproj/Localizable.strings
    trunk/zh_TW.lproj/MainMenu.strings

Modified: trunk/Base.lproj/MainMenu.xib
===================================================================
--- trunk/Base.lproj/MainMenu.xib       2024-03-20 16:33:26 UTC (rev 14118)
+++ trunk/Base.lproj/MainMenu.xib       2024-03-20 16:56:48 UTC (rev 14119)
@@ -851,14 +851,6 @@
                                     <action selector="doZoomToSelection:" 
target="-1" id="902"/>
                                 </connections>
                             </menuItem>
-                            <menuItem isSeparatorItem="YES" id="911">
-                                <modifierMask key="keyEquivalentModifierMask" 
command="YES"/>
-                            </menuItem>
-                            <menuItem title="Use Current View Settings as 
Default" id="886">
-                                <connections>
-                                    <action 
selector="savePDFSettingToDefaults:" target="-1" id="901"/>
-                                </connections>
-                            </menuItem>
                         </items>
                     </menu>
                 </menuItem>

Modified: trunk/SKMainWindowController_Actions.h
===================================================================
--- trunk/SKMainWindowController_Actions.h      2024-03-20 16:33:26 UTC (rev 
14118)
+++ trunk/SKMainWindowController_Actions.h      2024-03-20 16:56:48 UTC (rev 
14119)
@@ -123,7 +123,6 @@
 - (IBAction)togglePresentation:(nullable id)sender;
 - (IBAction)performFit:(nullable id)sender;
 - (IBAction)password:(nullable id)sender;
-- (IBAction)savePDFSettingToDefaults:(nullable id)sender;
 - (IBAction)chooseTransition:(nullable id)sender;
 - (IBAction)toggleCaseInsensitiveSearch:(nullable id)sender;
 - (IBAction)toggleWholeWordSearch:(nullable id)sender;

Modified: trunk/SKMainWindowController_Actions.m
===================================================================
--- trunk/SKMainWindowController_Actions.m      2024-03-20 16:33:26 UTC (rev 
14118)
+++ trunk/SKMainWindowController_Actions.m      2024-03-20 16:56:48 UTC (rev 
14119)
@@ -959,13 +959,6 @@
         [pdfView setPacerSpeed:[[sender title] doubleValue]];
 }
 
-- (IBAction)savePDFSettingToDefaults:(id)sender {
-    if ([self interactionMode] == SKNormalMode)
-        [[NSUserDefaults standardUserDefaults] setObject:[self 
currentPDFSettings] forKey:SKDefaultPDFDisplaySettingsKey];
-    else if ([self interactionMode] != SKPresentationMode)
-        [[NSUserDefaults standardUserDefaults] setObject:[self 
currentPDFSettings] forKey:SKDefaultFullScreenPDFDisplaySettingsKey];
-}
-
 - (IBAction)chooseTransition:(id)sender {
     NSWindowLevel level = NSNormalWindowLevel;
     if (interactionMode == SKPresentationMode) {

Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m   2024-03-20 16:33:26 UTC (rev 14118)
+++ trunk/SKMainWindowController_UI.m   2024-03-20 16:56:48 UTC (rev 14119)
@@ -1919,12 +1919,6 @@
             [menuItem setState:(NSInteger)round(speed) == s ? 
NSControlStateValueOn : NSControlStateValueOff];
         }
         return YES;
-    } else if (action == @selector(savePDFSettingToDefaults:)) {
-        if ([self interactionMode] == SKFullScreenMode)
-            [menuItem setTitle:NSLocalizedString(@"Use Current View Settings 
as Default for Full Screen", @"Menu item title")];
-        else
-            [menuItem setTitle:NSLocalizedString(@"Use Current View Settings 
as Default", @"Menu item title")];
-        return [self interactionMode] != SKPresentationMode && [self 
hasOverview] == NO && [[self pdfDocument] isLocked] == NO;
     } else if (action == @selector(chooseTransition:)) {
         return [[self pdfDocument] pageCount] > 1;
     } else if (action == @selector(toggleCaseInsensitiveSearch:)) {

Modified: trunk/de.lproj/Localizable.strings
===================================================================
(Binary files differ)

Modified: trunk/de.lproj/MainMenu.strings
===================================================================
(Binary files differ)

Modified: trunk/en.lproj/Localizable.strings
===================================================================
(Binary files differ)

Modified: trunk/en.lproj/MainMenu.strings
===================================================================
(Binary files differ)

Modified: trunk/es.lproj/Localizable.strings
===================================================================
(Binary files differ)

Modified: trunk/es.lproj/MainMenu.strings
===================================================================
(Binary files differ)

Modified: trunk/fr.lproj/Localizable.strings
===================================================================
(Binary files differ)

Modified: trunk/fr.lproj/MainMenu.strings
===================================================================
(Binary files differ)

Modified: trunk/it.lproj/Localizable.strings
===================================================================
(Binary files differ)

Modified: trunk/it.lproj/MainMenu.strings
===================================================================
(Binary files differ)

Modified: trunk/ja.lproj/Localizable.strings
===================================================================
(Binary files differ)

Modified: trunk/ja.lproj/MainMenu.strings
===================================================================
(Binary files differ)

Modified: trunk/nl.lproj/Localizable.strings
===================================================================
(Binary files differ)

Modified: trunk/nl.lproj/MainMenu.strings
===================================================================
(Binary files differ)

Modified: trunk/pl.lproj/Localizable.strings
===================================================================
(Binary files differ)

Modified: trunk/pl.lproj/MainMenu.strings
===================================================================
(Binary files differ)

Modified: trunk/ru.lproj/Localizable.strings
===================================================================
(Binary files differ)

Modified: trunk/ru.lproj/MainMenu.strings
===================================================================
(Binary files differ)

Modified: trunk/zh_CN.lproj/Localizable.strings
===================================================================
(Binary files differ)

Modified: trunk/zh_CN.lproj/MainMenu.strings
===================================================================
(Binary files differ)

Modified: trunk/zh_TW.lproj/Localizable.strings
===================================================================
(Binary files differ)

Modified: trunk/zh_TW.lproj/MainMenu.strings
===================================================================
(Binary files differ)

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to