Revision: 14122
          http://sourceforge.net/p/skim-app/code/14122
Author:   hofman
Date:     2024-03-22 16:45:09 +0000 (Fri, 22 Mar 2024)
Log Message:
-----------
Mixed state for selected find pane state when searching and not showing find 
pane

Modified Paths:
--------------
    trunk/SKMainWindowController_UI.m

Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m   2024-03-20 18:13:02 UTC (rev 14121)
+++ trunk/SKMainWindowController_UI.m   2024-03-22 16:45:09 UTC (rev 14122)
@@ -1852,13 +1852,13 @@
             [menuItem setTitle:NSLocalizedString(@"Show Notes Pane", @"Menu 
item title")];
         return [self interactionMode] != SKPresentationMode;
     } else if (action == @selector(changeLeftSidePaneState:)) {
-        [menuItem setState:mwcFlags.leftSidePaneState == 
(SKLeftSidePaneState)[menuItem tag] && [self displaysFindPane] == NO ? 
NSControlStateValueOn : NSControlStateValueOff];
+        [menuItem setState:mwcFlags.leftSidePaneState != 
(SKLeftSidePaneState)[menuItem tag] && [self displaysFindPane] == NO ? 
NSControlStateValueOn : NSControlStateValueOff];
         return (SKLeftSidePaneState)[menuItem tag] == SKSidePaneStateThumbnail 
|| [[pdfView document] outlineRoot];
     } else if (action == @selector(changeRightSidePaneState:)) {
         [menuItem setState:mwcFlags.rightSidePaneState == 
(SKRightSidePaneState)[menuItem tag] ? NSControlStateValueOn : 
NSControlStateValueOff];
         return [self interactionMode] != SKPresentationMode;
     } else if (action == @selector(changeFindPaneState:)) {
-        [menuItem setState:((SKFindPaneState)mwcFlags.findPaneState == 
(SKFindPaneState)[menuItem tag] && [self displaysFindPane]) ? 
NSControlStateValueOn : NSControlStateValueOff];
+        [menuItem setState:(SKFindPaneState)mwcFlags.findPaneState != 
(SKFindPaneState)[menuItem tag] ? NSControlStateValueOff : [self 
displaysFindPane] ? NSControlStateValueOn : NSControlStateValueMixed];
         [menuItem setHidden:[[self searchString] length] == 0];
         return  [[self searchString] length] > 0;
     } else if (action == @selector(toggleOverview:)) {

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to