[Skim-app-commit] SF.net SVN: skim-app:[14221] trunk

[hofman--- via Skim-app-commit]

Revision: 14221
          http://sourceforge.net/p/skim-app/code/14221
Author:   hofman
Date:     2024-04-19 09:35:28 +0000 (Fri, 19 Apr 2024)
Log Message:
-----------
Don't use CGRectGetMinX/Y on non-fully initialized rect

Modified Paths:
--------------
    trunk/SKBasePDFView.m
    trunk/SKMainWindowController_FullScreen.m

Modified: trunk/SKBasePDFView.m
===================================================================
--- trunk/SKBasePDFView.m       2024-04-18 17:04:48 UTC (rev 14220)
+++ trunk/SKBasePDFView.m       2024-04-19 09:35:28 UTC (rev 14221)
@@ -367,8 +367,8 @@
     rect = CGContextConvertRectToDeviceSpace(context, rect);
     r.origin.x = round(CGRectGetMinX(rect));
     r.origin.y = round(CGRectGetMinY(rect));
-    r.size.width = round(CGRectGetMaxX(rect)) - CGRectGetMinX(r);
-    r.size.height = round(CGRectGetMaxY(rect)) - CGRectGetMinY(r);
+    r.size.width = round(CGRectGetMaxX(rect)) - r.origin.x;
+    r.size.height = round(CGRectGetMaxY(rect)) - r.origin.y;
     return CGRectGetWidth(r) > 0.0 && CGRectGetHeight(r) > 0.0 ? 
CGContextConvertRectToUserSpace(context, r) : NSZeroRect;
 }
 

Modified: trunk/SKMainWindowController_FullScreen.m
===================================================================
--- trunk/SKMainWindowController_FullScreen.m   2024-04-18 17:04:48 UTC (rev 
14220)
+++ trunk/SKMainWindowController_FullScreen.m   2024-04-19 09:35:28 UTC (rev 
14221)
@@ -350,8 +350,8 @@
     rect = CGContextConvertRectToDeviceSpace(context, rect);
     r.origin.x = round(CGRectGetMinX(rect));
     r.origin.y = round(CGRectGetMinY(rect));
-    r.size.width = round(CGRectGetMaxX(rect)) - CGRectGetMinX(r);
-    r.size.height = round(CGRectGetMaxY(rect)) - CGRectGetMinY(r);
+    r.size.width = round(CGRectGetMaxX(rect)) - r.origin.x;
+    r.size.height = round(CGRectGetMaxY(rect)) - r.origin.y;
     return CGRectGetWidth(r) > 0.0 && CGRectGetHeight(r) > 0.0 ? 
CGContextConvertRectToUserSpace(context, r) : NSZeroRect;
 }
 

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit