Revision: 14382
http://sourceforge.net/p/skim-app/code/14382
Author: hofman
Date: 2024-07-17 09:31:08 +0000 (Wed, 17 Jul 2024)
Log Message:
-----------
Expose options to add new notes through selection and to set and/or update text
of notes from selection in Notes menu, add default values for preferences
Modified Paths:
--------------
trunk/Base.lproj/MainMenu.xib
trunk/InitialUserDefaults.plist
trunk/SKMainWindowController_Actions.h
trunk/SKMainWindowController_Actions.m
trunk/SKMainWindowController_UI.m
trunk/SKPDFView.m
trunk/SKStringConstants.h
trunk/SKStringConstants.m
trunk/de.lproj/MainMenu.strings
trunk/en.lproj/MainMenu.strings
trunk/es.lproj/MainMenu.strings
trunk/fr.lproj/MainMenu.strings
trunk/it.lproj/MainMenu.strings
trunk/ja.lproj/MainMenu.strings
trunk/nl.lproj/MainMenu.strings
trunk/pl.lproj/MainMenu.strings
trunk/ru.lproj/MainMenu.strings
trunk/zh_CN.lproj/MainMenu.strings
trunk/zh_TW.lproj/MainMenu.strings
Modified: trunk/Base.lproj/MainMenu.xib
===================================================================
--- trunk/Base.lproj/MainMenu.xib 2024-07-16 14:01:14 UTC (rev 14381)
+++ trunk/Base.lproj/MainMenu.xib 2024-07-17 09:31:08 UTC (rev 14382)
@@ -575,6 +575,35 @@
<menuItem isSeparatorItem="YES" id="Rz2-R1-S3M">
<modifierMask key="keyEquivalentModifierMask"
command="YES"/>
</menuItem>
+ <menuItem title="Adding Note" id="0SY-XV-MJ6">
+ <modifierMask key="keyEquivalentModifierMask"/>
+ <menu key="submenu" title="Adding Note"
id="mRt-Cd-Hqu">
+ <items>
+ <menuItem title="Require Selection"
id="fQV-e9-aL8">
+ <modifierMask
key="keyEquivalentModifierMask"/>
+ <connections>
+ <action
selector="toggleNewNoteRequiresSelection:" target="-1" id="zY0-n8-Mhr"/>
+ </connections>
+ </menuItem>
+ <menuItem isSeparatorItem="YES"
id="3Fh-oG-fp6"/>
+ <menuItem title="Set Text From
Selection" tag="2" id="LFo-FX-uJN">
+ <modifierMask
key="keyEquivalentModifierMask"/>
+ <connections>
+ <action
selector="toggleUpdateContentsFromEnclosedText:" target="-1" id="BWu-Ke-hvw"/>
+ </connections>
+ </menuItem>
+ <menuItem title="Update Text When
Dragging" tag="1" id="vJT-dX-1b5">
+ <modifierMask
key="keyEquivalentModifierMask"/>
+ <connections>
+ <action
selector="toggleUpdateContentsFromEnclosedText:" target="-1" id="KrN-vr-fIu"/>
+ </connections>
+ </menuItem>
+ </items>
+ </menu>
+ </menuItem>
+ <menuItem isSeparatorItem="YES" id="8cB-UN-KPY">
+ <modifierMask key="keyEquivalentModifierMask"
command="YES"/>
+ </menuItem>
<menuItem title="Edit Note" id="691">
<modifierMask key="keyEquivalentModifierMask"/>
<connections>
Modified: trunk/InitialUserDefaults.plist
===================================================================
--- trunk/InitialUserDefaults.plist 2024-07-16 14:01:14 UTC (rev 14381)
+++ trunk/InitialUserDefaults.plist 2024-07-17 09:31:08 UTC (rev 14382)
@@ -234,6 +234,10 @@
<true/>
<key>SKGrammarCheckingEnabled</key>
<false/>
+ <key>SKNewNoteRequiresSelection</key>
+ <false/>
+ <key>SKDisableUpdateContentsFromEnclosedText</key>
+ <integer>0</integer>
</dict>
<key>ResettableKeys</key>
<dict>
Modified: trunk/SKMainWindowController_Actions.h
===================================================================
--- trunk/SKMainWindowController_Actions.h 2024-07-16 14:01:14 UTC (rev
14381)
+++ trunk/SKMainWindowController_Actions.h 2024-07-17 09:31:08 UTC (rev
14382)
@@ -117,6 +117,8 @@
- (IBAction)searchNotes:(nullable id)sender;
- (IBAction)toggleFullscreen:(nullable id)sender;
- (IBAction)togglePresentation:(nullable id)sender;
+- (IBAction)toggleNewNoteRequiresSelection:(id)sender;
+- (IBAction)toggleUpdateContentsFromEnclosedText:(id)sender;
- (IBAction)performFit:(nullable id)sender;
- (IBAction)password:(nullable id)sender;
- (IBAction)chooseTransition:(nullable id)sender;
Modified: trunk/SKMainWindowController_Actions.m
===================================================================
--- trunk/SKMainWindowController_Actions.m 2024-07-16 14:01:14 UTC (rev
14381)
+++ trunk/SKMainWindowController_Actions.m 2024-07-17 09:31:08 UTC (rev
14382)
@@ -1125,6 +1125,19 @@
[self enterPresentation];
}
+- (IBAction)toggleNewNoteRequiresSelection:(id)sender {
+ NSUserDefaults *sud = [NSUserDefaults standardUserDefaults];
+ [sud setBool:NO == [sud boolForKey:SKNewNoteRequiresSelectionKey]
forKey:SKNewNoteRequiresSelectionKey];
+}
+
+- (IBAction)toggleUpdateContentsFromEnclosedText:(id)sender {
+ NSUserDefaults *sud = [NSUserDefaults standardUserDefaults];
+ NSInteger value = [sud
integerForKey:SKDisableUpdateContentsFromEnclosedTextKey];
+ NSInteger option = [sender tag];
+ value = value >= option ? 0 : option;
+ [sud setInteger:value forKey:SKDisableUpdateContentsFromEnclosedTextKey];
+}
+
- (IBAction)performFindPanelAction:(id)sender {
if ([self interactionMode] == SKPresentationMode) {
NSBeep();
Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m 2024-07-16 14:01:14 UTC (rev 14381)
+++ trunk/SKMainWindowController_UI.m 2024-07-17 09:31:08 UTC (rev 14382)
@@ -1926,6 +1926,14 @@
} else if (action == @selector(toggleAutoResizeNoteRows:)) {
[menuItem setState:mwcFlags.autoResizeNoteRows ? NSControlStateValueOn
: NSControlStateValueOff];
return YES;
+ } else if (action == @selector(toggleNewNoteRequiresSelection:)) {
+ [menuItem setState:[[NSUserDefaults standardUserDefaults]
boolForKey:SKNewNoteRequiresSelectionKey] ? NSControlStateValueOn :
NSControlStateValueOff];
+ return YES;
+ } else if (action == @selector(toggleUpdateContentsFromEnclosedText:)) {
+ NSInteger value = [[NSUserDefaults standardUserDefaults]
integerForKey:SKDisableUpdateContentsFromEnclosedTextKey];
+ NSInteger option = [menuItem tag];
+ [menuItem setState:value < option ? NSControlStateValueOn :
NSControlStateValueOff];
+ return option == 2 || value < 2;
} else if (action == @selector(performFindPanelAction:)) {
if ([self interactionMode] == SKPresentationMode)
return NO;
Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m 2024-07-16 14:01:14 UTC (rev 14381)
+++ trunk/SKPDFView.m 2024-07-17 09:31:08 UTC (rev 14382)
@@ -134,7 +134,6 @@
#define SKMoveReadingBarModifiersKey @"SKMoveReadingBarModifiers"
#define SKResizeReadingBarModifiersKey @"SKResizeReadingBarModifiers"
-#define SKNewNoteRequiresSelectionKey @"SKNewNoteRequiresSelection"
#define SKUseToolModeCursorsKey @"SKUseToolModeCursors"
#define SKMagnifyWithMousePressedKey @"SKMagnifyWithMousePressed"
#define SKPacerSpeedKey @"SKPacerSpeed"
Modified: trunk/SKStringConstants.h
===================================================================
--- trunk/SKStringConstants.h 2024-07-16 14:01:14 UTC (rev 14381)
+++ trunk/SKStringConstants.h 2024-07-17 09:31:08 UTC (rev 14382)
@@ -131,6 +131,7 @@
extern NSString *SKDisableModificationDateKey;
extern NSString *SKDisableAnimationsKey;
extern NSString *SKDisableUpdateContentsFromEnclosedTextKey;
+extern NSString *SKNewNoteRequiresSelectionKey;
extern NSString *SKCaseInsensitiveSearchKey;
extern NSString *SKWholeWordSearchKey;
extern NSString *SKCaseInsensitiveNoteSearchKey;
Modified: trunk/SKStringConstants.m
===================================================================
--- trunk/SKStringConstants.m 2024-07-16 14:01:14 UTC (rev 14381)
+++ trunk/SKStringConstants.m 2024-07-17 09:31:08 UTC (rev 14382)
@@ -131,6 +131,7 @@
NSString *SKDisableModificationDateKey = @"SKDisableModificationDate";
NSString *SKDisableAnimationsKey = @"SKDisableAnimations";
NSString *SKDisableUpdateContentsFromEnclosedTextKey =
@"SKDisableUpdateContentsFromEnclosedText";
+NSString *SKNewNoteRequiresSelectionKey = @"SKNewNoteRequiresSelection";
NSString *SKCaseInsensitiveSearchKey = @"SKCaseInsensitiveSearch";
NSString *SKWholeWordSearchKey = @"SKWholeWordSearch";
NSString *SKCaseInsensitiveNoteSearchKey = @"SKCaseInsensitiveNoteSearch";
Modified: trunk/de.lproj/MainMenu.strings
===================================================================
(Binary files differ)
Modified: trunk/en.lproj/MainMenu.strings
===================================================================
(Binary files differ)
Modified: trunk/es.lproj/MainMenu.strings
===================================================================
(Binary files differ)
Modified: trunk/fr.lproj/MainMenu.strings
===================================================================
(Binary files differ)
Modified: trunk/it.lproj/MainMenu.strings
===================================================================
(Binary files differ)
Modified: trunk/ja.lproj/MainMenu.strings
===================================================================
(Binary files differ)
Modified: trunk/nl.lproj/MainMenu.strings
===================================================================
(Binary files differ)
Modified: trunk/pl.lproj/MainMenu.strings
===================================================================
(Binary files differ)
Modified: trunk/ru.lproj/MainMenu.strings
===================================================================
(Binary files differ)
Modified: trunk/zh_CN.lproj/MainMenu.strings
===================================================================
(Binary files differ)
Modified: trunk/zh_TW.lproj/MainMenu.strings
===================================================================
(Binary files differ)
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
