Revision: 14525
http://sourceforge.net/p/skim-app/code/14525
Author: hofman
Date: 2024-10-07 15:39:12 +0000 (Mon, 07 Oct 2024)
Log Message:
-----------
remove unnecessary getter
Modified Paths:
--------------
trunk/SKPresentationOptionsSheetController.h
trunk/SKPresentationOptionsSheetController.m
Modified: trunk/SKPresentationOptionsSheetController.h
===================================================================
--- trunk/SKPresentationOptionsSheetController.h 2024-10-07 15:29:40 UTC
(rev 14524)
+++ trunk/SKPresentationOptionsSheetController.h 2024-10-07 15:39:12 UTC
(rev 14525)
@@ -73,7 +73,6 @@
@property (nonatomic, readonly) SKLabeledTransitionInfo *transition;
@property (nonatomic, nullable, copy) NSArray<SKLabeledTransitionInfo *>
*transitions;
@property (nonatomic, nullable, readonly) NSArray<SKLabeledTransitionInfo *>
*currentTransitions;
-@property (nonatomic, nullable, readonly) NSArray<NSDictionary<NSString *, id>
*> *pageTransitions;
@property (nonatomic, nullable, readonly) NSDocument *notesDocument;
@property (nonatomic, readonly) NSInteger notesDocumentOffset;
@property (nonatomic, readonly) NSUndoManager *undoManager;
Modified: trunk/SKPresentationOptionsSheetController.m
===================================================================
--- trunk/SKPresentationOptionsSheetController.m 2024-10-07 15:29:40 UTC
(rev 14524)
+++ trunk/SKPresentationOptionsSheetController.m 2024-10-07 15:39:12 UTC
(rev 14525)
@@ -85,7 +85,7 @@
@implementation SKPresentationOptionsSheetController
@synthesize notesDocumentPopUpButton, tableView, stylePopUpButton, okButton,
cancelButton, previewButton, tableWidthConstraint, boxLeadingConstraint,
arrayController, separate, transition, transitions, undoManager;
-@dynamic currentTransitions, pageTransitions, notesDocument,
notesDocumentOffset;
+@dynamic currentTransitions, notesDocument, notesDocumentOffset;
+ (NSSet *)keyPathsForValuesAffectingValueForKey:(NSString *)key {
NSSet *keyPaths = [super keyPathsForValuesAffectingValueForKey:key];
@@ -254,7 +254,10 @@
SKTransitionController *transitionController = [controller
transitionControllerCreating:separate || [transition style] != SKNoTransition];
if (transitionController) {
[transitionController setTransition:transition];
- [transitionController setPageTransitions:[self
pageTransitions]];
+ if (separate && [transitions count])
+ [transitionController setPageTransitions:[transitions
valueForKey:PROPERTIES_KEY]];
+ else
+ [transitionController setPageTransitions:nil];
[[controller undoManager]
setActionName:NSLocalizedString(@"Change Transitions", @"Undo action name")];
}
}
@@ -458,13 +461,6 @@
return separate ? transitions : @[transition];
}
-- (NSArray *)pageTransitions {
- if (separate && [transitions count])
- return [transitions valueForKey:PROPERTIES_KEY];
- else
- return nil;
-}
-
- (NSDocument *)notesDocument {
[self window];
return [[notesDocumentPopUpButton selectedItem] representedObject];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
