[Skim-app-commit] SF.net SVN: skim-app:[14549] trunk

[hofman--- via Skim-app-commit]

Revision: 14549
          http://sourceforge.net/p/skim-app/code/14549
Author:   hofman
Date:     2024-10-12 15:11:06 +0000 (Sat, 12 Oct 2024)
Log Message:
-----------
remove some unneeded properties

Modified Paths:
--------------
    trunk/SKPresentationOptionsSheetController.h
    trunk/SKPresentationOptionsSheetController.m

Modified: trunk/SKPresentationOptionsSheetController.h
===================================================================
--- trunk/SKPresentationOptionsSheetController.h        2024-10-12 14:58:22 UTC 
(rev 14548)
+++ trunk/SKPresentationOptionsSheetController.h        2024-10-12 15:11:06 UTC 
(rev 14549)
@@ -69,18 +69,12 @@
 @property (nonatomic, nullable, strong) IBOutlet NSButton *okButton, 
*cancelButton, *previewButton;
 @property (nonatomic, nullable, strong) IBOutlet NSLayoutConstraint 
*boxLeadingConstraint, *tableWidthConstraint;
 @property (nonatomic, nullable, strong) IBOutlet NSArrayController 
*arrayController;
+
 @property (nonatomic) BOOL separate;
-@property (nonatomic, readonly) SKLabeledTransitionInfo *transition;
 @property (nonatomic, copy) NSArray<SKLabeledTransitionInfo *> *transitions;
-@property (nonatomic, nullable, readonly) NSDocument *notesDocument;
-@property (nonatomic, readonly) NSInteger notesDocumentOffset;
-@property (nonatomic, readonly) NSUndoManager *undoManager;
 
 - (instancetype)initForController:(SKMainWindowController *)aController;
 
-- (void)startObservingTransitions:(NSArray<SKLabeledTransitionInfo *> *)infos;
-- (void)stopObservingTransitions:(NSArray<SKLabeledTransitionInfo *> *)infos;
-
 - (IBAction)preview:(nullable id)sender;
 
 @end

Modified: trunk/SKPresentationOptionsSheetController.m
===================================================================
--- trunk/SKPresentationOptionsSheetController.m        2024-10-12 14:58:22 UTC 
(rev 14548)
+++ trunk/SKPresentationOptionsSheetController.m        2024-10-12 15:11:06 UTC 
(rev 14549)
@@ -76,13 +76,17 @@
 #pragma mark -
 
 @interface SKPresentationOptionsSheetController ()
+
 - (NSArray *)makeTransitions:(NSArray *)properties;
+
+- (void)startObservingTransitions:(NSArray<SKLabeledTransitionInfo *> *)infos;
+- (void)stopObservingTransitions:(NSArray<SKLabeledTransitionInfo *> *)infos;
+
 @end
 
 @implementation SKPresentationOptionsSheetController
 
-@synthesize notesDocumentPopUpButton, tableView, stylePopUpButton, okButton, 
cancelButton, previewButton, tableWidthConstraint, boxLeadingConstraint, 
arrayController, separate, transition, transitions, undoManager;
-@dynamic notesDocument, notesDocumentOffset;
+@synthesize notesDocumentPopUpButton, tableView, stylePopUpButton, okButton, 
cancelButton, previewButton, tableWidthConstraint, boxLeadingConstraint, 
arrayController, separate, transitions;
 
 - (instancetype)initForController:(SKMainWindowController *)aController {
     self = [super init];
@@ -288,8 +292,9 @@
                 [[[controller document] undoManager] 
setActionName:NSLocalizedString(@"Change Transitions", @"Undo action name")];
             }
         }
-        [controller setPresentationNotesDocument:[self notesDocument]];
-        [controller setPresentationNotesOffset:[self notesDocumentOffset]];
+        NSMenuItem *notesDocumentItem = [notesDocumentPopUpButton 
selectedItem];
+        [controller setPresentationNotesDocument:[notesDocumentItem 
representedObject]];
+        [controller setPresentationNotesOffset:[notesDocumentItem tag]];
         [super dismissSheet:sender];
     }
 }
@@ -455,16 +460,6 @@
     }
 }
 
-- (NSDocument *)notesDocument {
-    [self window];
-    return [[notesDocumentPopUpButton selectedItem] representedObject];
-}
-
-- (NSInteger)notesDocumentOffset {
-    [self window];
-    return [[notesDocumentPopUpButton selectedItem] tag];
-}
-
 #pragma mark Undo
 
 - (void)observeUndoManagerCheckpoint:(NSNotification *)notification {

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit